web_view_scheduler_impl.cc(135)] Check failed: pending_resource_load_count_ >= 0 (-1 vs. 0) |
||
Issue descriptionCrash when running layout tests. Reverting https://crrev.com/9599120a7c4d3532a0aaeed18b81ed6e9892381c locally fixes this. $ third_party/WebKit/Tools/Scripts/run-webkit-tests --target=Default --no-retry-failures http/tests/serviceworker/fetch-csp.html [1/1] http/tests/serviceworker/fetch-csp.html failed unexpectedly (renderer crashed) crash log for renderer (pid <unknown>): STDOUT: CONSOLE ERROR: Refused to load the image 'http://localhost:8000/serviceworker/resources/fetch-access-control.php?PNGIMAGE' because it violates the following Content Security Policy directive: "img-src http://127.0.0.1:8000". STDOUT: STDOUT: CONSOLE ERROR: Refused to load the image 'http://localhost:8000/serviceworker/resources/fetch-access-control.php?PNGIMAGE' because it violates the following Content Security Policy directive: "img-src http://127.0.0.1:8000". STDOUT: STDOUT: #CRASHED - renderer STDERR: [1:1:0707/142610:1282082602883:FATAL:web_view_scheduler_impl.cc(135)] Check failed: pending_resource_load_count_ >= 0 (-1 vs. 0) STDERR: #0 0x7f2f9a1cb53e base::debug::StackTrace::StackTrace() STDERR: #1 0x7f2f9a1ec69b logging::LogMessage::~LogMessage() STDERR: #2 0x7f2f92a0a0eb scheduler::WebViewSchedulerImpl::decrementPendingResourceLoadCount() STDERR: #3 0x7f2f944e92b0 blink::FrameFetchContext::dispatchDidFail() STDERR: #4 0x7f2f943ab1e5 blink::ResourceFetcher::didReceiveResponse() STDERR: #5 0x7f2f943b3a7c blink::ResourceLoader::didReceiveResponse() STDERR: #6 0x7f2f98c84e25 content::WebURLLoaderImpl::Context::OnReceivedResponse() STDERR: #7 0x7f2f98c63158 content::ResourceDispatcher::OnReceivedResponse() STDERR: #8 0x7f2f98c6594d
,
Jul 7 2016
It appears in that test FrameFetchContext::dispatchDidFail is being called twice for the same resource. I'll try and figure out why.
,
Jul 7 2016
I have a patch in review to fix this: https://codereview.chromium.org/2125273002#
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c316c6a98fd2e49bd92c3d90855cffc57df3608 commit 4c316c6a98fd2e49bd92c3d90855cffc57df3608 Author: alexclarke <alexclarke@chromium.org> Date: Thu Jul 07 18:49:11 2016 Fix a problem with duplicate calls to FrameFetchContext::dispatchDidFail In some circumstances FrameFetchContext::dispatchDidFail can get called twice for the same resource. This patch fixes an assumption by the blink scheduler that this scenario didn't happen. BUG= 626218 Review-Url: https://codereview.chromium.org/2125273002 Cr-Commit-Position: refs/heads/master@{#404191} [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/components/scheduler/renderer/web_frame_scheduler_impl.cc [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/components/scheduler/renderer/web_frame_scheduler_impl.h [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/components/scheduler/renderer/web_view_scheduler_impl.cc [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/components/scheduler/renderer/web_view_scheduler_impl.h [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/components/scheduler/renderer/web_view_scheduler_impl_unittest.cc [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp [modify] https://crrev.com/4c316c6a98fd2e49bd92c3d90855cffc57df3608/third_party/WebKit/public/platform/WebFrameScheduler.h
,
Jul 8 2016
This should be fixed now. |
||
►
Sign in to add a comment |
||
Comment 1 by alexclarke@chromium.org
, Jul 7 2016