New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626200 link

Starred by 7 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 681951
issue 661754
issue 663155

Blocking:
issue 500962



Sign in to add a comment

Promote fixed-position elements to a layer on low-dpi where possible?

Project Member Reported by rbyers@chromium.org, Jul 7 2016

Issue description

Our UMA stats indicate that 38% of wheel scrolls on Windows occur on the main thread due to a "non-layer viewport constrained object" (i.e. position:fixed).  By far the most common reason for scrolling on main.

https://uma.googleplex.com/p/chrome/histograms/?endDate=07-05-2016&dayCount=1&histograms=Renderer4.MainThreadWheelScrollReason&fixupData=true&showMax=true&filters=platform%2Ceq%2CW%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

Like for  issue 381840  couldn't we detect the common case of a position:fixed element on an opaque background and automatically promote it to a layer without loosing sub-pixel AA?  At a minimum it seems we should really be able to cut this 38% of scrolls down a fair bit.

There's an example in  issue 500962 .  Is there any reason we can't auto-promote that header to a layer?

 
Blocking: 500962
Status: Available (was: Unconfirmed)
Plausible.
Should definitely be possible. I suspect we're going to have a long tail of issues with regards to when we can still draw with LCD-text. On  issue 500962  for example, the layer created for the sticky-bar is not opaque because its layer bounds extend further than the backround for some reason.

I'm hoping to tackle some of the easier wins in this long tail, starting with opaque background scrollers of course.
Owner: flackr@chromium.org
Status: Assigned (was: Available)
Great, assigning to you then.  Yep, I think we should just use UMA to help prioritize which of the not-too-hard scenarios to focus on.  Note that it appears that position:fixed is MUCH more common a reason for main thread scrolling than overflow:scroll (~38% vs. 5% on Windows).
Another in-the-wild example of where this could be done https://nodejs.org/api/stream.html
Status: Started (was: Assigned)
We may need more strict conditions on when we can promote but I have a patch which promotes opaque fixed position elements on low dpi here: https://codereview.chromium.org/2318243002
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b497cdb2b02803980368504e2a361c5d48750f27

commit b497cdb2b02803980368504e2a361c5d48750f27
Author: flackr <flackr@chromium.org>
Date: Fri Oct 14 22:05:45 2016

Turn on CompositeOpaqueFixedPosition for tests and rebase tests.

BUG=626200

Review-Url: https://codereview.chromium.org/2369603002
Cr-Commit-Position: refs/heads/master@{#425487}

[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/deprecation/css-clip-and-clip-path.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/absolute-position-changed.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-move-after-scroll.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-of-fixed-move-after-scroll.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/fixed-move-after-scroll.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-absolute-scrolled.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-fixed-scrolled.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/fixed.html
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/paint/invalidation/resources/repaint-with-scrollbar-change.html
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/filters/blur-filter-page-scroll-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/blur-filter-page-scroll-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-parents-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[add] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27/third_party/WebKit/Source/web/tests/data/fixed-position-losing-backing.html

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cc2be82c9163a939cbd1731fba27aaf196ad361

commit 1cc2be82c9163a939cbd1731fba27aaf196ad361
Author: joedow <joedow@chromium.org>
Date: Fri Oct 14 23:37:12 2016

Revert of Turn on CompositeOpaqueFixedPosition for test and rebase tests. (patchset #7 id:120001 of https://codereview.chromium.org/2369603002/ )

Reason for revert:
CL is suspected to be causing failures on multiple mac builders:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/25159

Original issue's description:
> Turn on CompositeOpaqueFixedPosition for tests and rebase tests.
>
> BUG=626200
>
> Committed: https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27
> Cr-Commit-Position: refs/heads/master@{#425487}

TBR=schenney@chromium.org,flackr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626200

Review-Url: https://codereview.chromium.org/2423643002
Cr-Commit-Position: refs/heads/master@{#425510}

[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/deprecation/css-clip-and-clip-path.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/absolute-position-changed.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-move-after-scroll.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-of-fixed-move-after-scroll.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/fixed-move-after-scroll.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-absolute-scrolled.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-fixed-scrolled.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/fixed.html
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/paint/invalidation/resources/repaint-with-scrollbar-change.html
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/filters/blur-filter-page-scroll-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/blur-filter-page-scroll-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-parents-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[delete] https://crrev.com/64e0b361f22ad031c22e25b4200d3c7a9d996846/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/1cc2be82c9163a939cbd1731fba27aaf196ad361/third_party/WebKit/Source/web/tests/data/fixed-position-losing-backing.html

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a26fbb6476bd1f691396cef2236bf4369ac13ec

commit 6a26fbb6476bd1f691396cef2236bf4369ac13ec
Author: flackr <flackr@chromium.org>
Date: Thu Oct 20 20:41:54 2016

Reland Turn on CompositeOpaqueFixedPosition for test and rebase tests. (patchset #7 id:120001 of https://codereview.chromium.org/2369603002/ )

TBR=schenney
BUG=626200

Review-Url: https://chromiumcodereview.appspot.com/2428153002
Cr-Commit-Position: refs/heads/master@{#426584}

[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt
[add] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/css3/filters/blur-filter-page-scroll-expected.png
[add] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/deprecation/css-clip-and-clip-path.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/absolute-position-changed.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-move-after-scroll.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-of-fixed-move-after-scroll.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/fixed-move-after-scroll.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-absolute-scrolled.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-fixed-scrolled.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/fixed.html
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/paint/invalidation/resources/repaint-with-scrollbar-change.html
[add] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.png
[add] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-parents-expected.png
[add] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png
[add] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec/third_party/WebKit/Source/web/tests/data/fixed-position-losing-backing.html

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7a5662a1de02e93aed48a8b41dccdef3832841

commit ab7a5662a1de02e93aed48a8b41dccdef3832841
Author: flackr <flackr@chromium.org>
Date: Tue Nov 01 22:51:32 2016

Only promote fixed position elements on low dpi without transform or opacity.

If the element has a transform or opacity it may lose LCD text if promoted.

TEST=CompositingReasonFinderTest.OnlyNonTransformedFixedLayersPromoted, CompositingReasonFinderTest.OnlyOpaqueFixedLayersPromoted
BUG=626200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2459393003
Cr-Commit-Position: refs/heads/master@{#429143}

[delete] https://crrev.com/1058ff73448a5ceaefc96e45d263057e17d01df7/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
[add] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/ab7a5662a1de02e93aed48a8b41dccdef3832841/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Blockedon: 661754
Labels: Hotlist-Threaded-Rendering
Labels: -Hotlist-ThreadedRendering
Blockedon: 681951
Labels: -Hotlist-Threaded-Rendering Hotlist-ThreadedRendering
Blockedon: 663155
Owner: yigu@chromium.org
Status: Assigned (was: Started)
Over to Yi who has been trying to get this enabled by default.
Cc: yigu@chromium.org
Owner: ----
Status: Available (was: Assigned)
Move self to cc as there is no plan working on this in the near future.
Will CompositeOpaqueFixedPosition be enabled? If not, can we remove the flag and associated code? I recently found this when implementing main thread scrolling reasons for BlinkGenPropertyTrees.
Owner: chrishtr@chromium.org
Status: Assigned (was: Available)
I'm going to send a patch now to delete the feature. We should not launch this
as implemented, and instead base it on the CAP architecture.
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/908ba038d0c0790e8e98eaf919f1d6856fcaf49e

commit 908ba038d0c0790e8e98eaf919f1d6856fcaf49e
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Dec 28 23:19:32 2018

[CI] Remove CompositeOpaqueFixedPosition runtime feature.

This feature has been stalled for a long time. Let's delete it
and re-add after CAP.

Bug: 626200

Change-Id: Ic1c7581221ba0e2e350c1572e1d7e04d12adad72
Reviewed-on: https://chromium-review.googlesource.com/c/1391737
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619204}
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder_test.cc
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/web_tests/compositing/layer-creation/fixed-position-under-transform-expected.txt
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/web_tests/compositing/rtl/rtl-fixed-overflow-expected.txt
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/web_tests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/web_tests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt
[modify] https://crrev.com/908ba038d0c0790e8e98eaf919f1d6856fcaf49e/third_party/blink/web_tests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt

Status: Available (was: Assigned)
Owner: ----

Sign in to add a comment