Make document-level wheel listeners passive by default? |
||||||||||||||||||||||||||||
Issue descriptionPlease provide a link to your UX implementation review here before requesting review.
,
Jul 7 2016
Oh, it is? Issue 599609 says specifically "touch scrolling" - I thought we were worried about also doing wheel because we don't have quite as compelling of a story there (eg. no equivalent for touch-action)? But yes, if we agree to do wheel at the same time, then yes this can be duped in.
,
Jul 7 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 7 2017
Putting in the backlog. We will revisit this once touchpad latching is enabled. We may not need to do this if the gains there are more than enough.
,
Jul 9
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 16
Now that we have latching this might be worth revisiting. Sahel, is this something you can take a look and see whether we might gain a considerable improvement in wheel scrolling or not?
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/667f001d9507c6ba636c93b1a831f333f5f475d8 commit 667f001d9507c6ba636c93b1a831f333f5f475d8 Author: Sahel Sharify <sahel@chromium.org> Date: Fri Jul 27 17:37:27 2018 Add use counter for document level wheel event listeners. This cl adds use counters to find out the ratio of the web pages that add document level wheel event listeners with passive:false, true, or unspecified. It also counts the number of document level wheel event listeners with passive:unspecified that preventDefault wheel events. This information is useful to investigate the potential performance benefits and risks of changing the default value of the passive option to be true for document level wheel/mousewheel event listeners. Bug: 626196 Change-Id: Ib0ee64b1a5085813d9b70073747ec3f544fbb660 Reviewed-on: https://chromium-review.googlesource.com/1148783 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#578695} [modify] https://crrev.com/667f001d9507c6ba636c93b1a831f333f5f475d8/third_party/blink/public/platform/web_feature.mojom [modify] https://crrev.com/667f001d9507c6ba636c93b1a831f333f5f475d8/third_party/blink/renderer/core/dom/events/event_target.cc [modify] https://crrev.com/667f001d9507c6ba636c93b1a831f333f5f475d8/third_party/blink/renderer/core/dom/events/event_target.h [modify] https://crrev.com/667f001d9507c6ba636c93b1a831f333f5f475d8/third_party/blink/renderer/core/events/wheel_event.cc [modify] https://crrev.com/667f001d9507c6ba636c93b1a831f333f5f475d8/third_party/blink/renderer/core/events/wheel_event.h [modify] https://crrev.com/667f001d9507c6ba636c93b1a831f333f5f475d8/tools/metrics/histograms/enums.xml
,
Aug 7
,
Aug 7
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7400e88b12dbf7142a4927778c983d19adaf72fe commit 7400e88b12dbf7142a4927778c983d19adaf72fe Author: Sahel Sharify <sahel@chromium.org> Date: Mon Aug 13 17:13:21 2018 Document level passive wheel event listeners behind a flag. With this change wheel event listeners that are registered on a window, window.document, window.document.body will be treated as passive if not specified otherwise. Intent to impl: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: I1561cd86ddd381e0405c84ba8f48ea7274d8906c Reviewed-on: https://chromium-review.googlesource.com/1162302 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582623} [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/chrome/browser/about_flags.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/chrome/browser/flag_descriptions.h [add] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/content/browser/renderer_host/input/wheel_event_listener_browsertest.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/content/child/runtime_features.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/content/public/common/content_features.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/content/public/common/content_features.h [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/content/test/BUILD.gn [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/third_party/blink/public/platform/web_runtime_features.h [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/third_party/blink/renderer/core/dom/events/event_target.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/third_party/blink/renderer/core/events/wheel_event.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/third_party/blink/renderer/platform/exported/web_runtime_features.cc [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/third_party/blink/renderer/platform/runtime_enabled_features.json5 [modify] https://crrev.com/7400e88b12dbf7142a4927778c983d19adaf72fe/tools/metrics/histograms/enums.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9187c7d059b7aa6342b39a19c7c32ba5aedd92cf commit 9187c7d059b7aa6342b39a19c7c32ba5aedd92cf Author: Sahel Sharify <sahel@chromium.org> Date: Wed Aug 22 15:08:18 2018 Add PassiveDocumentWheelEventListeners to fieldtrial_testing_config Please find the intent ot implement here: https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: Id77ceb7352629a6a9417617602d330919904ed44 Reviewed-on: https://chromium-review.googlesource.com/1183538 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585020} [modify] https://crrev.com/9187c7d059b7aa6342b39a19c7c32ba5aedd92cf/testing/variations/fieldtrial_testing_config.json
,
Aug 23
Explicitly selecting platforms, excluding iOS, per the Finch config.
,
Aug 23
Thanks
,
Oct 10
,
Oct 31
,
Nov 1
,
Nov 6
Bulk Edit: Updating Rollout-Type to Default since no Launch/Target Exp bits are set. Please update Rollout-Type to Finch and include Launch/Target Exp bits if not intended be launched as default
,
Nov 9
,
Nov 9
,
Nov 9
,
Nov 9
,
Nov 9
,
Nov 9
,
Nov 9
,
Nov 9
Automatic generating of FLT Launch data.
,
Nov 10
,
Nov 21
Updating this issue's FLT-Conversion label. Please do not modify this value.
,
Nov 29
,
Nov 29
Bulk updating old OWP-Launch bugs to once again be public. OWP-Launch (previously used as public/transparent blink launch process) was not supposed to have been remapped to Type=Launch.
,
Nov 30
Preparing this issue to be converted back into the old format. Will change Type back to 'Feature' after.
,
Nov 30
,
Nov 30
,
Dec 5
,
Dec 5
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f177dfeb50648a57ab331d9f7619a9ba4c1aeb87 commit f177dfeb50648a57ab331d9f7619a9ba4c1aeb87 Author: Sahel Sharify <sahel@chromium.org> Date: Thu Dec 20 19:56:58 2018 WPT for passive document level wheel event listeners. This cl adds a WPT test for passive document level wheel event listeners intervention. It also adds a message to let developers know when they call preventDefault on wheel events that are non-cancelable due to the intervention. Bug: 626196 Change-Id: I7f51ff4560de7ffa7bf89cab9e5332daa6cb70c0 Reviewed-on: https://chromium-review.googlesource.com/c/1383323 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#618297} [modify] https://crrev.com/f177dfeb50648a57ab331d9f7619a9ba4c1aeb87/third_party/blink/renderer/core/events/wheel_event.cc [modify] https://crrev.com/f177dfeb50648a57ab331d9f7619a9ba4c1aeb87/third_party/blink/web_tests/TestExpectations [add] https://crrev.com/f177dfeb50648a57ab331d9f7619a9ba4c1aeb87/third_party/blink/web_tests/external/wpt/dom/events/document-level-wheel-event-listener-passive-by-default-manual.html [add] https://crrev.com/f177dfeb50648a57ab331d9f7619a9ba4c1aeb87/third_party/blink/web_tests/external/wpt_automation/dom/events/document-level-wheel-event-listener-passive-by-default-manual-automation.js [modify] https://crrev.com/f177dfeb50648a57ab331d9f7619a9ba4c1aeb87/third_party/blink/web_tests/resources/testharnessreport.js
,
Dec 20
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bbf0564486f6147dc1d646817c54ebdb7129df4 commit 5bbf0564486f6147dc1d646817c54ebdb7129df4 Author: Sahel Sharify <sahel@chromium.org> Date: Wed Jan 16 16:52:00 2019 Enable Passive document level wheel event listeners flag by default. Intent to ship: https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: Ib6d5587a323cb56f8da29d746453a87a3a23bfe5 Reviewed-on: https://chromium-review.googlesource.com/c/1409609 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623260} [modify] https://crrev.com/5bbf0564486f6147dc1d646817c54ebdb7129df4/content/public/common/content_features.cc [modify] https://crrev.com/5bbf0564486f6147dc1d646817c54ebdb7129df4/third_party/blink/renderer/core/testing/data/wheel-event-handler.html [modify] https://crrev.com/5bbf0564486f6147dc1d646817c54ebdb7129df4/third_party/blink/renderer/core/testing/internals.cc [modify] https://crrev.com/5bbf0564486f6147dc1d646817c54ebdb7129df4/third_party/blink/renderer/platform/runtime_enabled_features.json5 |
||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Jul 7 2016