New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626157 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Public Session Sign in pod is not displaying Avatar at the correct position

Project Member Reported by trapti@chromium.org, Jul 6 2016

Issue description

Peppy Device
M	ChromeOS	Chrome	ARC	Type	Channel
53	8530.5.0	53.0.2785.4	3026157	release	dev

Public Session Sign in pod is not displaying Avatar at the correct position.

Steps To Reproduce:
1)Enable Public Session for the enrolled device with M53 Build.
2)Click on the Public Session pod to display SessionLocale in the PS Sign In pod, along with the default language-pre-selected. 


Expected Result:SessionLocale should appear in the PS Sign In pod, along with the default language-pre-selected and Avatar should be displayed at right position

Actual Result:Avatar looks shifted on the session locale display.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.


 
IMG_9296.JPG
893 KB View Download
Cc: sdurais...@google.com vidster@chromium.org
Owner: ----
I'm not the right owner for this.

Comment 3 by dskaram@google.com, Jul 7 2016

Cc: xiy...@chromium.org achuith@chromium.org
+Xiyuan +Achuith, any idea who owns the pod?

+Krishna, are you also seeing this on M53?
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 7 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug Type-Bug-Regression
Owner: sammiequon@chromium.org
Status: Assigned (was: Available)
sammiequon@, might be related with css change in https://codereview.chromium.org/2027683003/. Could you take a look?
Cc: jdufault@chromium.org
Labels: -M-54 -MovedFrom-53 ReleaseBlock-Stable M-53
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57237df88100d360800e6131cce2434642071023

commit 57237df88100d360800e6131cce2434642071023
Author: sammiequon <sammiequon@chromium.org>
Date: Fri Jul 08 20:41:45 2016

Fixed regression bug regarding pod on public session.

Bug was caused by having transitions for the image and sign in indicator for the user pod, while the image pane stays 100%. So when we are in the public account user pod the image will be centered.

BUG= 626157 

Review-Url: https://codereview.chromium.org/2130143002
Cr-Commit-Position: refs/heads/master@{#404482}

[modify] https://crrev.com/57237df88100d360800e6131cce2434642071023/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/57237df88100d360800e6131cce2434642071023/ui/login/account_picker/user_pod_row.js

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Marking as started since this needs to be merged into m53.
Labels: Merge-Request-53

Comment 12 by dimu@google.com, Jul 18 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 18 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5486668a33af7e2db65c2172be94f83e0f5d8331

commit 5486668a33af7e2db65c2172be94f83e0f5d8331
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Jul 18 22:08:24 2016

Fixed regression bug regarding pod on public session.

Bug was caused by having transitions for the image and sign in indicator for the user pod, while the image pane stays 100%. So when we are in the public account user pod the image will be centered.

BUG= 626157 

Review-Url: https://codereview.chromium.org/2130143002
Cr-Commit-Position: refs/heads/master@{#404482}
(cherry picked from commit 57237df88100d360800e6131cce2434642071023)

Review URL: https://codereview.chromium.org/2157993003 .

Cr-Commit-Position: refs/branch-heads/2785@{#203}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/5486668a33af7e2db65c2172be94f83e0f5d8331/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/5486668a33af7e2db65c2172be94f83e0f5d8331/ui/login/account_picker/user_pod_row.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in M53-Candy Device

M	ChromeOS	Chrome	ARC	Type	Channel
53	8530.24.0	53.0.2785.23	3077498	release	dev 

Sign in to add a comment