New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626153 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 640763



Sign in to add a comment

Let users remove any language

Project Member Reported by michae...@chromium.org, Jul 6 2016

Issue description

Languages with variants (like "English (United States)" and "English") have weird behavior in both Options and Material Settings.

Assuming "English (United States)" is your locale, "English" gets added automatically and cannot be removed. This is by design ( issue 192309 ) but is unexpected and frustrating.

In Options, removing English will pretend to work, but it comes back when you refresh.

In Settings, removing English doesn't work at all.

Maybe we should hide unremovable items like "English" in Settings, but it's a hard UI problem, we can talk more online.

There's also some weird behavior trying to re-order these languages (try adding a bunch of languages and variants): in Settings clicking Move up/Move down sometimes does nothing. In Options it pretends to work, but reverts on refresh.
 
 Issue 621941  has been merged into this issue.
Labels: Hotlist-MD-Settings-Languages
Status: Available (was: Untriaged)
Summary: Let users remove any language (was: Language settings have a mind of their own)
Blockedon: 640763
This is blocked on a technical decision to be made in  issue 640763 . If we decide to keep the status quo, we'll need some way to convey in the UI that certain languages are "required" if other languages are enabled.
Labels: OS-Linux OS-Mac OS-Windows
I think this actually works correctly in Chrome OS due to the use of language.preferred_languages.
Labels: -Pri-2 Pri-3
Marking as P3 since this is a strict improvement over the old UI (though seems like something we should definitely fix).
Cc: msrchandra@chromium.org kkaluri@chromium.org ranjitkan@chromium.org michae...@chromium.org nyerramilli@chromium.org
 Issue 682566  has been merged into this issue.
Labels: OS-Chrome
Owner: michae...@chromium.org
Status: Started (was: Available)
This is hard to do in the general case, but there are cases we can at least hard-code a fix for, namely the most common one (English/English (United States)).
Labels: -OS-Chrome M-59
Status: Assigned (was: Started)
Have a patch but am still tweaking tests. Since this doesn't occur on CrOS I'll punt to M59.
Labels: -M-59
As this is blocked, removing milestone.

The spot patch to fix en-US in particular was trickier than I expected and not very useful for the complexity it would add.
Cc: steve...@chromium.org claudiomagni@chromium.org
 Issue 735902  has been merged into this issue.
Cc: yyushkina@chromium.org
Owner: ----
Status: Available (was: Assigned)
Bulk unassigning my language settings bugs as I am no longer working on Settings. 
Labels: Hotlist-LanguageSettings
Owner: claudiomagni@chromium.org
Status: Fixed (was: Available)
Fixed in M65.

Sign in to add a comment