New issue
Advanced search Search tips

Issue 626119 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 595538



Sign in to add a comment

Need search over passwords

Project Member Reported by tbuck...@chromium.org, Jul 6 2016

Issue description

Users should be able to search over their saved passwords.
 
Blocking: 595538
Owner: hcarmona@chromium.org
Status: Started (was: Available)
I've stareted working on this: http://crrev.com/2092763004
Cc: bettes@chromium.org
Updated screenshots for password search CL.
no_results.png
196 KB View Download
not_searching.png
236 KB View Download
some_results.png
210 KB View Download
 Issue 627638  has been merged into this issue.
Awesome! One nit, the search placeholder should remain "Search passwords" even when there are no results.

@bettes do you have any guidance for how the empty list should look?
"nothing to see here" is my search term that didn't return results.
 Issue 628049  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dd148fc30594c576d61fac30e67b1dd8f4977a5

commit 9dd148fc30594c576d61fac30e67b1dd8f4977a5
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Jul 21 01:04:00 2016

[MD Settings] Implement search in material design passwords.

Includes test. Screenshot in bug.

BUG= 626119 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2092763004
Cr-Commit-Position: refs/heads/master@{#406736}

[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/app/settings_strings.grdp
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/settings_page/compiled_resources2.gyp
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/settings_page/settings_subpage.js
[add] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[add] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/settings_page/settings_subpage_search.js
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/9dd148fc30594c576d61fac30e67b1dd8f4977a5/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
@hcarmona, I'm not seeing this in recent updates. Is it working for you?

OS: Chrome
Version: 53.0.2785.36 dev
 Issue 632327  has been merged into this issue.
Status: Fixed (was: Assigned)
Marking this as fixed. I can see the search field on ChromeOS 54.0.2831.0 Canary

Sign in to add a comment