New issue
Advanced search Search tips

Issue 626115 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Unify MockExecutive and MockExecutive2 in webkitpy.common.system.executive_mock.

Project Member Reported by qyears...@chromium.org, Jul 6 2016

Issue description

There's a fixme in the code already; filing an issue here to track this task.

https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
 
Labels: -Type-Bug Type-Feature
Status: Available (was: Unconfirmed)
Owner: qyears...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c149b1840394dd6fd974c82bb4c35d30eb033a3f

commit c149b1840394dd6fd974c82bb4c35d30eb033a3f
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Jan 03 19:30:13 2017

Unify MockExecutive and MockExecutive2.

After this, there's no choice between MockExecutive and MockExecutive2.

This was preceded by preparation CL http://crrev.com/2588863002.

BUG= 626115 

Review-Url: https://codereview.chromium.org/2605873004
Cr-Commit-Position: refs/heads/master@{#441181}

[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
[modify] https://crrev.com/c149b1840394dd6fd974c82bb4c35d30eb033a3f/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment