Make the missing plugin UI more scalable. |
||||||||||||||
Issue descriptionProblem: For small form factor Flash Player content, the missing plugin content placeholder doesn't scale well (i.e. it's fixed dimensions cause it to get clipped). Please see examples attached. Background: We're planning on removing Flash Player from the default distribution bundle for Chrome and fetch it passively (i.e. in the background, after the first 6 minutes of usage) or actively (i.e. if the user attempts to access a site that directly instantiates a Flash object, prior to us downloading the component). Previously only users who had click-to-play (or a similar variant) enabled would see these prompts, which was a less common configuration. Now this UI will be surfaced to a potentially much larger audience, we should potentially revisit it's treatment.
,
Jul 7 2016
,
Jul 7 2016
waffles: The Android version runs the NonLoadablePluginPlaceholder which should be disabled_plugin.html. The *_plugin.html files could use some modernization and consolidation. There's a separate bug to make the text always visible instead of on hover, and I support that too: https://bugs.chromium.org/p/chromium/issues/detail?id=62082 It's a 5 digit bug... Tommy
,
Jul 7 2016
waffles: You can trigger the NonLoadable one on desktop by hacking up this method here: https://cs.chromium.org/chromium/src/chrome/renderer/chrome_content_renderer_client.cc?q=NonLoadablePlugin&sq=package:chromium&l=590
,
Jul 7 2016
Fantastic, thanks. There's an <if expr="is_android"> in blocked_plugin.html; but it sounds like you're saying Android always uses disabled_plugin.html. If so, it should be fine to remove/ignore that `if` statement. Is that correct?
,
Jul 7 2016
waffles: Yes I believe that is so. the is_android is probably a leftover.
,
Jul 7 2016
Great, then I'll make some adjustments to the files and submit that for UI review.
,
Jul 7 2016
,
Aug 4 2016
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/025e686e1be72066fa73e659cccec597d8212fe2 commit 025e686e1be72066fa73e659cccec597d8212fe2 Author: waffles <waffles@chromium.org> Date: Fri Aug 05 22:18:45 2016 Update missing/downloading/blocked/unsupported/disabled plugin UI. BUG= 626107 , 62082 Review-Url: https://codereview.chromium.org/2155493002 Cr-Commit-Position: refs/heads/master@{#410187} [modify] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/app/generated_resources.grd [modify] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/renderer/resources/plugins/blocked_plugin.html [modify] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/renderer/resources/plugins/disabled_plugin.html [delete] https://crrev.com/9e4be9ba438612c55668fc95a55000e4a4cc0869/chrome/renderer/resources/plugins/plugin_blocked.png [delete] https://crrev.com/9e4be9ba438612c55668fc95a55000e4a4cc0869/chrome/renderer/resources/plugins/plugin_blocked_android.png [modify] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/renderer/resources/plugins/plugin_placeholders.css [modify] https://crrev.com/025e686e1be72066fa73e659cccec597d8212fe2/chrome/renderer/resources/plugins/plugin_poster.html
,
Aug 5 2016
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85faa55b91d5e5a450dbbec7567b6dfe807b335c commit 85faa55b91d5e5a450dbbec7567b6dfe807b335c Author: waffles <waffles@chromium.org> Date: Thu Aug 25 20:01:40 2016 Change pepper flash name. ("pepper_flash" is displaying in plugin placeholders; we prefer "Adobe Flash Player"). BUG= 626107 Review-Url: https://codereview.chromium.org/2284443002 Cr-Commit-Position: refs/heads/master@{#414516} [modify] https://crrev.com/85faa55b91d5e5a450dbbec7567b6dfe807b335c/chrome/browser/component_updater/pepper_flash_component_installer.cc |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by waff...@chromium.org
, Jul 6 2016