New issue
Advanced search Search tips

Issue 626079 link

Starred by 3 users
Status: WontFix
Owner:
sammiequon@chromium.org
Closed: Oct 15
Cc:
tbuck...@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 603217



Sign in to add a comment

Enable feature notification for quick unlock

Project Member Reported by jdufault@chromium.org, Jul 6 2016 
A feature notification should advertise to the user that they can setup PIN unlock to more quickly unlock their device.

From the PRD:

- Upon unlocking a device that supports Quick Unlock for the first time, a one-time notification should prompt users to set up a Quick Unlock for faster unlock.
- Note: if disabled by policy, no notification should be shown
- Clicking the notification should bring the user to the Quick Unlock section of Settings.
- The notification should be easy to dismiss.

Comment 1 by jdufault@chromium.org, Jul 6 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2b9f1278e86ff8e05c7d06f8bd315c792da2662

commit b2b9f1278e86ff8e05c7d06f8bd315c792da2662
Author: malaykeshav <malaykeshav@chromium.org>
Date: Wed Jul 13 09:25:54 2016

Implements the feature notification for Quick Unlock

Displays a feature notification informing the user about quick unlock.
Upon clicking the notification the user is taken to the settings page.

The UI strings used in the notification are still TODO and not final.

BUG= 626079 
COMPONENT=Chrome OS, Quick Unlock, Preferences, Strings

Review-Url: https://codereview.chromium.org/2128053002
Cr-Commit-Position: refs/heads/master@{#405105}

[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ash/ash_chromeos_strings.grdp
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ash/common/system/system_notifier.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ash/common/system/system_notifier.h
[add] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[add] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.h
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/session/user_session_manager.h
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/common/pref_names.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/common/pref_names.h
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ui/strings/ui_strings.grd
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2b9f1278e86ff8e05c7d06f8bd315c792da2662

commit b2b9f1278e86ff8e05c7d06f8bd315c792da2662
Author: malaykeshav <malaykeshav@chromium.org>
Date: Wed Jul 13 09:25:54 2016

Implements the feature notification for Quick Unlock

Displays a feature notification informing the user about quick unlock.
Upon clicking the notification the user is taken to the settings page.

The UI strings used in the notification are still TODO and not final.

BUG= 626079 
COMPONENT=Chrome OS, Quick Unlock, Preferences, Strings

Review-Url: https://codereview.chromium.org/2128053002
Cr-Commit-Position: refs/heads/master@{#405105}

[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ash/ash_chromeos_strings.grdp
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ash/common/system/system_notifier.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ash/common/system/system_notifier.h
[add] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[add] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.h
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/login/session/user_session_manager.h
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/common/pref_names.cc
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/chrome/common/pref_names.h
[modify] https://crrev.com/b2b9f1278e86ff8e05c7d06f8bd315c792da2662/ui/strings/ui_strings.grd

Comment 4 by malaykeshav@chromium.org, Jul 13 2016

Owner: jdufault@chromium.org

Comment 5 by jdufault@chromium.org, Sep 9 2016

Labels: -M-54 M-55
Notification should work but it still needs to get enabled.

Comment 6 by jdufault@chromium.org, Sep 9 2016

Summary: Enable feature notification for quick unlock (was: Feature notification for quick unlock)

Comment 7 by jdufault@chromium.org, Oct 7 2016

Cc: tbuck...@chromium.org
Tom, do we want to launch the notification on m55 or wait until m56?

Comment 8 by jdufault@chromium.org, Feb 14 2017

Cc: -sammiequon@chromium.org
Owner: sammiequon@chromium.org

Comment 9 by sammiequon@chromium.org, Jun 9 2017

Labels: OS-Chrome
Tom, should we launch this? What should the strings say if so?

Comment 10 by jdufault@chromium.org, Jun 10 2017 

I believe UI review wants us to hold off on this for the time being.

Comment 11 by afakhry@chromium.org, Feb 23 2018

Components: UI>Shell>LockScreen

Comment 12 by sammiequon@chromium.org, Oct 15

Status: WontFix (was: Assigned)
I think this code has been deleted now.
►

Sign in to add a comment