Mac GN: Build flag differences in //third_party/icu |
|||
Issue descriptionIn comparing the Mac GN and Mac GYP builds, I found the following differences in compilation flags: New in GN compared to GYP: -Wno-switch -Wno-unused-const-variable -Wno-unused-function If these differences are non-material to your project, you can close this as WontFix. Otherwise, please adjust the flags in BUILD.gn.
,
Jul 25 2016
Sorry that I haven't come here earlier. I guess those additional options should be ok. What needs to be done is to remove them if not necessary in the current version of ICU.
,
Jul 25 2016
You just need to edit the //third_party/icu/BUILD.gn file to remove the flags.
,
Aug 5 2016
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/deps/icu.git/+/b71982a946ec7b88fb64078e8b492a5ce0e0c656 commit b71982a946ec7b88fb64078e8b492a5ce0e0c656 Author: Jungshik Shin <jshin@chromium.org> Date: Mon Aug 08 20:26:04 2016 Use -Wno-unused-const-variable only on Windows + clang BUG= 626078 TEST=trybot succeeds on non-Windows. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/2218673002 . [modify] https://crrev.com/b71982a946ec7b88fb64078e8b492a5ce0e0c656/BUILD.gn
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/deps/icu.git/+/b71982a946ec7b88fb64078e8b492a5ce0e0c656 commit b71982a946ec7b88fb64078e8b492a5ce0e0c656 Author: Jungshik Shin <jshin@chromium.org> Date: Mon Aug 08 20:26:04 2016 Use -Wno-unused-const-variable only on Windows + clang BUG= 626078 TEST=trybot succeeds on non-Windows. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/2218673002 . [modify] https://crrev.com/b71982a946ec7b88fb64078e8b492a5ce0e0c656/BUILD.gn
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/094a721de6c93093a7e7d868cd73e7eb1a1abdd8 commit 094a721de6c93093a7e7d868cd73e7eb1a1abdd8 Author: jshin <jshin@chromium.org> Date: Tue Aug 09 20:14:20 2016 Roll ICU from ef5c7353 to 53ce6316 The range has: - IANA timezone database update to 2016f (Windows ICU data dll only. Others were updated previously) - Two GN clean-ups. For details, see https://chromium.googlesource.com/chromium/deps/icu.git/+log/ef5c7353..53ce6316 BUG=473288, 626078 , 632438 TEST=See GN CLs above TBR=rserek@chromium.org Review-Url: https://codereview.chromium.org/2229733004 Cr-Commit-Position: refs/heads/master@{#410790} [modify] https://crrev.com/094a721de6c93093a7e7d868cd73e7eb1a1abdd8/DEPS
,
Aug 9 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by erikc...@chromium.org
, Jul 8 2016Owner: js...@chromium.org
Status: Assigned (was: Untriaged)