Mac GN: Build flag differences in //third_party/ffmpeg |
||
Issue descriptionIn comparing the Mac GN and Mac GYP builds, I found the following differences in compilation flags: New in GN compared to GYP: -fomit-frame-pointer -fPIC -Wno-logical-op-parentheses If these differences are non-material to your project, you can close this as WontFix. Otherwise, please adjust the flags in BUILD.gn.
,
Jul 11 2016
-fPIC seems to be in both .gyp and .gn, ditto for omit-frame-pointer. The only different one seems to be -Wno-logical-op-parenthesis. How did you determine that the other two are missing?
,
Jul 11 2016
I think the difference is that in GYP, cflags are ignored on Mac and xcode_settings are used instead, whereas in GN, cflags are used. These differences were found by comparing the ninja commands when building the chrome target for an official, branded build.
,
Jul 11 2016
Ah, probably we could restrict them all to mac only if we wanted, but it seems simpler to keep them for all platforms. I think this is non-material. |
||
►
Sign in to add a comment |
||
Comment 1 by yini...@chromium.org
, Jul 11 2016Status: Assigned (was: Untriaged)