New issue
Advanced search Search tips

Issue 626071 link

Starred by 2 users
Status: Verified
Owner:
ayatane@chromium.org
Closed: Aug 2016
Cc:
ayatane@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 630018


Sign in to add a comment

deployment_test servo update is likely to fail

Reported by jrbarnette@chromium.org, Jul 6 2016 
At the start of `deployment_test`, the script checks whether
the servo needs update, and if necessary, waits for the update
to complete and then reboots the servo.

Unfortunately, during deployment it's normal for the servo not
to have a board setting, and the update code in ServoHost fails
if servod fails to start after reboot.  That means in many cases,
`deployment_test` will fail with an error report like this:
    ============
    Failures
    ============
    chromeos4-row4-rack7-host7     servo host chromeos4-row4-rack7-host7-servo failed to come back from reboot.

The code needs to forgive/ignore this condition.

Comment 1 by jrbarnette@chromium.org, Jul 20 2016

Blockedon: 630018
Status: Available (was: Unconfirmed)
The planned servo repair rework in  bug 630018  will
make "wait for update, then reboot" into a repair action.
That action will be triggered by such verification failures
as "servod isn't working".  That will allow replacing virtually
all of the servo setup, verification, and initialization in
deployment_test with a call to repair the servo host.

A side effect of that change will be to fix this bug.

Comment 2 by dshi@chromium.org, Jul 26 2016

Labels: Hotlist-Fixit

Comment 3 by jrbarnette@chromium.org, Jul 27 2016

Cc: ayatane@chromium.org

Comment 4 by jrbarnette@chromium.org, Jul 28 2016

Owner: ayatane@chromium.org
Status: Assigned (was: Available)

Comment 5 by jrbarnette@chromium.org, Jul 28 2016

Labels: -Pri-3 Pri-1

Comment 6 by jrbarnette@chromium.org, Jul 28 2016 

This fix can't wait until my repair rework is done.
The existing code can be fixed by catching the specific
exception and ignoring it.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5662e872acbf9ec98e89531750c89b2c64232185

commit 5662e872acbf9ec98e89531750c89b2c64232185
Author: Allen Li <ayatane@google.com>
Date: Fri Jul 29 17:45:46 2016

[autotest] Ignore expected servo update error during deploy

During deploy process, the servo may not be configured with a board,
which is needed for the servo update.  This is an expected situation;
however, it will raise an exception that was not caught.

The sleep() before calling verify() on the servo is increased to be more
reliable.

BUG= chromium:626071 
TEST=Reproduced bug and re-ran with fix

Change-Id: Id28cb4af62af9316ace5b8ebf51ce099dd4e5ec5
Reviewed-on: https://chromium-review.googlesource.com/364649
Commit-Ready: Allen Li <ayatane@google.com>
Tested-by: Allen Li <ayatane@google.com>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/5662e872acbf9ec98e89531750c89b2c64232185/site_utils/deployment/install.py

Comment 8 by ayatane@chromium.org, Aug 8 2016

Status: Fixed (was: Assigned)

Comment 9 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 10 by patricia@chromium.org, Aug 29 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment