Mac GN: Build flag differences in //third_party/skia and //skia |
|||
Issue descriptionIn comparing the Mac GN and Mac GYP builds, I found the following differences in compilation flags: Missing in GN compared to GYP: -Wheader-hygiene (both //skia/ext and //third_party/skia) -Wstring-conversion (just //third_party/skia) If these differences are non-material to your project, you can close this as WontFix. Otherwise, please adjust the flags in BUILD.gn.
,
Jul 6 2016
+mtklein@ who wrote third_party/skia/BUILD.gn and probably knows who best to assess this.
,
Jul 6 2016
Can you list out the full path to the BUILD.gn and GYP files you're taking about? chromium/src/skia/BUILD.gn? chromium/src/third_party/skia/BUILD.gn? I don't see any BUILD.gn file in chromium/src/skia/ext. Is Chrome using chromium/src/third_party/skia/BUILD.gn? If so, neat, but scary and totally unintentional. But, back to the main point... it doesn't really matter what warning flags Chrome compiles Skia with. Mostly we pay attention to our own bots and Chrome's via the auto roller. Probably can WontFix, but it's fine to make them agree one way or the other if you like. We don't use -Wheader-hygeiene outside Chrome. We do have -Wstring-conversion enabled on our Clang bots.
,
Jul 6 2016
This is for Skia building within Chromium (specifically, the difference is for files that get compiled into the chrome target). So I believe the GN file would be chromium/src/skia/BUILD.gn. There is no reason to make the flags match exactly, we just want to ensure all the differences are accounted for. It sounds like this may just be WontFix if Skia, built outside of chrome, has its flags set properly.
,
Jul 6 2016
sgtm |
|||
►
Sign in to add a comment |
|||
Comment 1 by rsesek@chromium.org
, Jul 6 2016