New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626070 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 622889



Sign in to add a comment

Mac GN: Build flag differences in //third_party/skia and //skia

Project Member Reported by rsesek@chromium.org, Jul 6 2016

Issue description

In comparing the Mac GN and Mac GYP builds, I found the following differences in compilation flags:

Missing in GN compared to GYP:

  -Wheader-hygiene (both //skia/ext and //third_party/skia)
  -Wstring-conversion (just //third_party/skia)

If these differences are non-material to your project, you can close this as WontFix. Otherwise, please adjust the flags in BUILD.gn.

 
Components: Internals>Skia
Cc: a.bah@chromium.org mtklein@chromium.org
+mtklein@ who wrote third_party/skia/BUILD.gn and probably knows who best to assess this.
Can you list out the full path to the BUILD.gn and GYP files you're taking about?

chromium/src/skia/BUILD.gn?  chromium/src/third_party/skia/BUILD.gn?  I don't see any BUILD.gn file in chromium/src/skia/ext.

Is Chrome using chromium/src/third_party/skia/BUILD.gn?  If so, neat, but scary and totally unintentional.

But, back to the main point... it doesn't really matter what warning flags Chrome compiles Skia with.  Mostly we pay attention to our own bots and Chrome's via the auto roller.  Probably can WontFix, but it's fine to make them agree one way or the other if you like.

We don't use -Wheader-hygeiene outside Chrome.  We do have -Wstring-conversion enabled on our Clang bots.
This is for Skia building within Chromium (specifically, the difference is for files that get compiled into the chrome target). So I believe the GN file would be chromium/src/skia/BUILD.gn.

There is no reason to make the flags match exactly, we just want to ensure all the differences are accounted for. It sounds like this may just be WontFix if Skia, built outside of chrome, has its flags set properly.
Status: WontFix (was: Untriaged)
sgtm

Sign in to add a comment