Mac GN: Build flag differences in //third_party/libyuv |
|||
Issue descriptionIn comparing the Mac GN and Mac GYP builds, I found the following differences in compilation flags: Missing in GN compared to GYP: -Wextra New in GN compared to GYP: -Wno-unused-variable If these differences are non-material to your project, you can close this as WontFix. Otherwise, please adjust the flags in BUILD.gn.
,
Jul 7 2016
BUILD.gn had warnings turned down. I dont see a good reason for that, so I've prepared a CL upstream in libyuv. Please review https://codereview.chromium.org/2130583003
,
Jul 7 2016
,
Jul 14 2016
Fixed in this CL https://codereview.chromium.org/2126333002
,
Jul 14 2016
,
Jul 14 2016
This CL is the actual GN change: https://codereview.chromium.org/2130583003 GN and GYP both are treated as chromium_code
,
Jul 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38d96aa1885a7886f96d5b6f8da28f58944c23cc commit 38d96aa1885a7886f96d5b6f8da28f58944c23cc Author: fbarchard <fbarchard@google.com> Date: Thu Jul 14 20:54:53 2016 roll libyuv from r1579 to r1608 roll libyuv for GN fix to chromium internal settings, enabling more warnings and consistant with gyp build options. Add ARGBExtractAlpha function. Fix YUV bilinear filter improved filter accuracy; uses 128-f instead of 127-f. unittest fixes for Arm scaler - use J420 for J422 pointing to same row, improving performance and accuracy. Fix ios jpeg build error. Fix BlendPlaneRow_SSSE3 impossible constraints on android full debug Fix unittests to avoid private row.h header. Fix vector_size(32) build error on yuv conversion for intel on gcc 4.4. BUG= chromium:626065 , libyuv:572 , libyuv:575 , libyuv:579 , libyuv:573 , libyuv:583 , chromium:601140 , libyuv:582 , libyuv:581 , chromium:601140 , libyuv:578 , libyuv:581 , libyuv:580 , libyuv:586 , libyuv:590 , webrtc:5006 , libyuv:593 , libyuv:592 , libyuv:594 , libyuv:595 , libyuv:597 , libyuv:599 , libyuv:598 , libyuv:600 , libyuv:602 , libyuv:605 , libyuv:610 , libyuv:612 , libyuv:618 , libyuv:620 , webrtc:6091 , webrtc:6094 , libyuv:616 , libyuv:623 , libyuv:624 , libyuv:625 TEST=try bots pass Review-Url: https://codereview.chromium.org/2151043002 Cr-Commit-Position: refs/heads/master@{#405565} [modify] https://crrev.com/38d96aa1885a7886f96d5b6f8da28f58944c23cc/DEPS |
|||
►
Sign in to add a comment |
|||
Comment 1 by fbarchard@chromium.org
, Jul 7 2016