New issue
Advanced search Search tips

Issue 626030 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 629092
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Sheriffbot-Auto-triage Rule: Open bugs with CL landed which are not modified for 6 months.

Project Member Reported by derat@chromium.org, Jul 6 2016

Issue description

Sheriffbot-Auto-triage Rule: Open bugs with CL landed which are not modified for 6 months.

Add Bug number which got updated:

http://crbug.com/361635
http://crbug.com/357533
http://crbug.com/322185
http://crbug.com/248762
http://crbug.com/248353
etc.

Issue/Concern or feedback:

I'm concerned that the Hotlist-OpenBugWithCL rule is going to result in a bunch of unfixed bugs being archived. I estimate that more than half of the bugs that I've seen this label added to still exist.

If the actual goal of this rule is to make people triage old bugs, I suppose it's successful (I'm triaging them because I'm scared that they'll be archived otherwise!). https://www.chromium.org/issue-tracking/autotriage says that it exists because "developers often forget to close the bugs after landing CLs", though, and I think that the auto-archiving behavior is overly aggressive for that.
 

Comment 1 by derat@chromium.org, Jul 8 2016

I continue to see a lot of false positives from this rule. It also doesn't handle reverted changes correctly; see e.g.  http://crbug.com/393243 .
Thanks for the report. I'm working on the fix to handle reverted changes correctly.

Comment 3 by derat@chromium.org, Jul 10 2016

Thanks. I've also seen many bugs where e.g. some refactoring to make the requested fix possible has landed, but not the fix itself.

Comment 4 by cda...@chromium.org, Jul 12 2016

CL is pending review and i'll land it tomorrow. We will also go thro' the bugs which got updated with the reverted cl and remove the sheriffbot comment.

Thanks

Comment 5 by derat@chromium.org, Jul 12 2016

Could you add a similar exception for bugs that have multiple human-generated comments after the last CL? That's a strong signal that they're still active.

I'm still seeing a lot of bugs where someone says, "I'll perform refactoring A first and then land fix B," and then only lands A. I'm concerned that many of those bugs are going to be closed soon.

Comment 6 by cda...@chromium.org, Jul 12 2016

Cc: -lafo...@chromium.org derat@chromium.org gov...@chromium.org
Owner: lafo...@chromium.org
The change to ignore issues when the last cl is reverted is added and deployed.
We went manually to the affected bugs and removed "Hotlist-OpenBugWithCL" label so it doesn't Archive automatically.

Assigning to Anthony for further inputs.

1. Reg "multiple human-generated comments" . Is "2" a good to consider or it should be more.
2. Do we also need to ignore any issues if it has "Blocked on:" label.

Thanks
Cc: -cda...@chromium.org lafo...@chromium.org
Owner: cda...@chromium.org
1. I like the spirit of the heuristic, but I've seen cases where people come back and say this is fixed and can be closed.  The probably need human inspection anyways to make a decision, so the annotation is probably appropriate.  Perhaps having a larger grace period for secondary reeving might be appropriate.

2. Yes, that should be fine.

Comment 8 by derat@chromium.org, Jul 18 2016

Here's what seems like another exception: if the bug is blocked on other not-closed bugs, it should probably be kept open, right? See e.g. issue 489441.

Comment 9 by cda...@chromium.org, Jul 18 2016

Added this to query to ignore blocking bugs (both blocked or has blocking bugs in it) the cl will be landed today.

Thanks
The cl to ignore blocking issues is landed and deployed.
Components: Tools>Stability>SheriffBot
We have manually cleaned up all the blocked and blocking issues affected by this rule.

Note: This rule is now suspended and more details can be found in issue 629092

Thanks

Comment 13 by aarya@google.com, Aug 5 2016

Mergedinto: 629092
Status: Duplicate (was: Assigned)

Sign in to add a comment