Ash should list repeatable, rather than non-repeatable, accelerators |
|||||
Issue descriptionash/accelerators/accelerator_table.cc currently has a kNonrepeatableActions array listing accelerators that shouldn't be repeated if the user holds down keys, but it's way out of date. We should instead just list the few accelerators that are intended to be repeatable -- from scanning the list, I suspect it's only around 14 of them.
,
Jul 6 2016
I only find RESTORE_TAB's current repeatability to be useful since Ctrl-W (handled by Chrome rather than ash) is repeatable and I sometimes trigger it accidentally. :-/
,
Jul 6 2016
Your short list sounds good to me. I don't have an opinion about SCALE_UI, MAGNIFY_SCREEN, and FOCUS_*_PANE and would just leave them as they are. RESTORE_TAB being repeatable is fine with me.
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c061dd11ada8a97335b2ef9b13757cdb780f84e8 commit c061dd11ada8a97335b2ef9b13757cdb780f84e8 Author: derat <derat@chromium.org> Date: Thu Jul 07 16:35:52 2016 ash: Explicitly enumerate repeatable accelerators. Instead of designating specific accelerators as non-repeatable (which is prone to getting outdated), keep track of the few accelerators that should be repeatable. Also make many probably-inadvertently-repeatable accelerators instead be non-repeatable. BUG= 626014 TEST=manual Review-Url: https://codereview.chromium.org/2130603002 Cr-Commit-Position: refs/heads/master@{#404161} [modify] https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8/ash/accelerators/accelerator_controller.h [modify] https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8/ash/accelerators/accelerator_table.cc [modify] https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8/ash/accelerators/accelerator_table.h [modify] https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8/ash/accelerators/accelerator_table_unittest.cc [modify] https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8/ash/accelerators/exit_warning_handler.h
,
Jul 7 2016
,
Aug 29 2016
,
Oct 7 2016
,
Oct 21 2016
Closing bug as per comment #3 and #4 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by derat@chromium.org
, Jul 6 2016