New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625993 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Field trial should be registered for a feature overridden in chrome://flags.

Project Member Reported by jkrcal@chromium.org, Jul 6 2016

Issue description

Variation parameters can be overridden via chrome://flags. Internally, a fresh trial group is created with the specified parameters. 

At the moment, the trial is not registered for the associated feature.
This should be fixed.
 

Comment 1 by jkrcal@chromium.org, Jul 11 2016

Labels: zine-16-07-11
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1d200873f13fbc0232dc4e5905b19a8885805dd

commit d1d200873f13fbc0232dc4e5905b19a8885805dd
Author: jkrcal <jkrcal@chromium.org>
Date: Thu Jul 14 15:04:24 2016

Registering field trial for a feature overridden in chrome://flags.

Variation parameters can be overridden via chrome://flags. Internally, a
fresh trial group is created with the specified parameters. Previously,
the trial was not registered for the associated feature.

This CL registers the trial for the given feature.

BUG= 625993 

Review-Url: https://codereview.chromium.org/2129543002
Cr-Commit-Position: refs/heads/master@{#405496}

[modify] https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd/chrome/browser/about_flags.cc
[modify] https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd/chrome/browser/about_flags.h
[modify] https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd/components/flags_ui/flags_state.cc
[modify] https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd/components/flags_ui/flags_state.h
[modify] https://crrev.com/d1d200873f13fbc0232dc4e5905b19a8885805dd/components/flags_ui/flags_state_unittest.cc

Comment 3 by jkrcal@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment