New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625988 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Bug



Sign in to add a comment

DeviceInertialSensorBrowserTest.LightOneOffInfintyTest crashing on Jelly Bean Tester and Marshmallow Tablet Tester (threading problem).

Project Member Reported by aber...@chromium.org, Jul 6 2016

Issue description


Crash is:

C  965.921s Main  [CRASH] DeviceInertialSensorBrowserTest.LightOneOffInfintyTest:
C  965.921s Main  [ RUN      ] DeviceInertialSensorBrowserTest.LightOneOffInfintyTest
C  965.921s Main  [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig.
C  965.921s Main  [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools.
C  965.921s Main  [ERROR:shell_android.cc(70)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): DeviceLight one-off Infinity event test
C  965.921s Main  [FATAL:device_sensor_host.cc(25)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on Chrome_IOThread.
C  965.921s Main  #00 0x7746c9ad /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x01fd09ad
C  965.921s Main  #01 0x75ac3827 /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x00627827
C  965.921s Main  #02 0x75ac38b3 /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x006278b3
C  965.921s Main  #03 0x75a08d1f /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x0056cd1f
C  965.921s Main  #04 0x75a01277 /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x00565277
C  965.921s Main  #05 0x75a0154f /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x0056554f
C  965.921s Main  #06 0x75dfc4dd /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x009604dd
C  965.921s Main  #07 0x774722f3 /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x01fd62f3
C  965.921s Main  #08 0x77472327 /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x01fd6327
C  965.921s Main  #09 0x774a2ac7 /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x02006ac7
C  965.921s Main  #10 0x7749f02f /data/app-lib/org.chromium.content_browsertests_apk-1/lib_content_browsertests__library.so+0x0200302f
C  965.921s Main  #11 0x4010a173 /system/lib/libc.so+0x0000d173
C  965.922s Main  #12 0x4010a30b /system/lib/libc.so+0x0000d30b
C  965.922s Main  #13 0xffffffff <unknown>
C  965.922s Main  
C  965.922s Main  [ERROR:test_suite.cc(254)] Currently running: DeviceInertialSensorBrowserTest.LightOneOffInfintyTest
C 

Looks as if it is likely to be related to https://codereview.chromium.org/2037513002, but I have yet to confirm this.
 
Status: Untriaged (was: Available)
Has recovered in the latest builds. Leaving open for now in case it comes back.

Comment 2 by dcheng@chromium.org, Jul 11 2016

Cc: timvolod...@chromium.org
 Issue 626199  has been merged into this issue.

Comment 3 by dcheng@chromium.org, Jul 11 2016

Cc: -sa...@chromium.org
Owner: sa...@chromium.org
Status: Assigned (was: Untriaged)
This is affecting the trybots. https://codereview.chromium.org/2134113002/ PS3 hits this failure on the Nexus 5X bots. Looking at  https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/, there's quite a few failures from this. We should figure out what's going on here.

Comment 4 by grt@chromium.org, Jul 18 2016

Labels: OS-Linux
This is happening consistently on Linux ASan Tests (sandboxed) as well (https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/27876). Please fix ASAP.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd34c46303e555ce506cf683eedf3bc95033548d

commit dd34c46303e555ce506cf683eedf3bc95033548d
Author: sammc <sammc@chromium.org>
Date: Thu Jul 21 23:46:50 2016

Use a ThreadChecker in DeviceSensorHost instead of DCHECK_CURRENTLY_ON.

BrowserThreads forget their identity during shutdown, causing
nonsensical errors like
"Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO).
Must be called on Chrome_IOThread; actually called on Chrome_IOThread."
if DCHECK_CURRENTLY_ON is used in something that is called from a
MessageLoop shutdown observer.

This CL fixes this problem in DeviceSensorHost by using a ThreadChecker
instead.

BUG= 625988 

Review-Url: https://codereview.chromium.org/2160913005
Cr-Commit-Position: refs/heads/master@{#406995}

[modify] https://crrev.com/dd34c46303e555ce506cf683eedf3bc95033548d/content/browser/device_sensors/device_sensor_browsertest.cc
[modify] https://crrev.com/dd34c46303e555ce506cf683eedf3bc95033548d/content/browser/device_sensors/device_sensor_host.cc
[modify] https://crrev.com/dd34c46303e555ce506cf683eedf3bc95033548d/content/browser/device_sensors/device_sensor_host.h

Comment 6 by sa...@chromium.org, Jul 26 2016

Status: Fixed (was: Assigned)

Comment 7 by jam@chromium.org, Jul 27 2016

Cc: roc...@chromium.org
This looks like a dup of  bug 631093  which Ken has a fix for in https://codereview.chromium.org/2180253003/

Sign in to add a comment