New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 625983



Sign in to add a comment
link

Issue 625984: Implement Flash YouTube embeds rewrite to HTML

Reported by mlamouri@chromium.org, Jul 6 2016 Project Member

Issue description

^
 

Comment 1 by omat...@gmail.com, Aug 3 2016

Can we have details here?

Why specifically does Youtube need special treatment?  Why can't they implement server side redirection from /v/ to /embed/?  Will other video services be offered the same?

Implementation is here:
https://codereview.chromium.org/2154233003/

Comment 2 by mlamouri@chromium.org, Aug 3 2016

An email was sent to chromium-dev@ with more information.

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0135598f6bf547463bc943100da4574c5f89930

commit e0135598f6bf547463bc943100da4574c5f89930
Author: kdsilva <kdsilva@google.com>
Date: Tue Aug 09 17:08:11 2016

Rewrite YouTube Flash embeds.

When a Flash embed for YouTube is detected, we automatically use HTML5 instead. This is done to reduce the overall usage of Flash in Chrome.

BUG= 625984 

Review-Url: https://codereview.chromium.org/2154233003
Cr-Commit-Position: refs/heads/master@{#410715}

[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/common/chrome_features.cc
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/common/chrome_features.h
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/renderer/DEPS
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/renderer/chrome_content_renderer_client_browsertest.cc
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/renderer/chrome_content_renderer_client_unittest.cc
[add] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/chrome/test/data/flash_embeds.html
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/content/renderer/render_frame_impl.h
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/third_party/WebKit/Source/web/FrameLoaderClientImpl.h
[modify] https://crrev.com/e0135598f6bf547463bc943100da4574c5f89930/third_party/WebKit/public/web/WebFrameClient.h

Comment 4 by mlamouri@chromium.org, Aug 9 2016

Summary: Implement Flash YouTube embeds rewrite to HTML (was: Implement Flash YouTube embeds rewrite to HTML behind Blink runtime flag)

Comment 6 by mlamouri@chromium.org, Aug 9 2016

Status: Fixed (was: Started)

Sign in to add a comment