ExecutionContextTask/createSameThreadTask()/createCrossThreadTask() are now mostly wrappers of WTF::Function/bind()/crossThreadBind(). We can replace ExecutionContextTask with WTF::Function to unify of tasks in Blink.
Should be assigned to yuryu@ but temporarily assigning to me just to mark this assigned.
Any updates on this? :)
I apologize for not updating this for such a long time! I will be able to spend more time beginning next week and start landing patches.
Thank you. Feel free to ask me or someone on the CC list if you need help or have questions :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e65b92f52d560ffa0d36850693ded14171719817 commit e65b92f52d560ffa0d36850693ded14171719817 Author: nhiroki <nhiroki@chromium.org> Date: Thu Jan 19 06:11:21 2017 FileSystem: Migrate ExecutionContextTask to WTF::Closure BUG= 625927 Review-Url: https://codereview.chromium.org/2645473005 Cr-Commit-Position: refs/heads/master@{#444661} [modify] https://crrev.com/e65b92f52d560ffa0d36850693ded14171719817/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp [modify] https://crrev.com/e65b92f52d560ffa0d36850693ded14171719817/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h [modify] https://crrev.com/e65b92f52d560ffa0d36850693ded14171719817/third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp [modify] https://crrev.com/e65b92f52d560ffa0d36850693ded14171719817/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04ff6239687ee823e9aa66254e4d506958366c7d commit 04ff6239687ee823e9aa66254e4d506958366c7d Author: nhiroki <nhiroki@chromium.org> Date: Thu Jan 19 07:26:29 2017 Worker: Consolidate postTask implementation WorkerGlobalScope and ThreadedWorkletGlobalScope have the same implementation of postTask(). These should be consolidated into WorkerOrWorkletGlobalScope::postTask(). BUG= 625927 Review-Url: https://codereview.chromium.org/2644833002 Cr-Commit-Position: refs/heads/master@{#444673} [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.h [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h [modify] https://crrev.com/04ff6239687ee823e9aa66254e4d506958366c7d/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8a03e2020bf9aad333ae60eb57541e7eafb4f24 commit e8a03e2020bf9aad333ae60eb57541e7eafb4f24 Author: nhiroki <nhiroki@chromium.org> Date: Thu Jan 19 09:22:07 2017 Worker: Move instrumentation flag check from WorkerThread to WorkerOrWorkletGlobalScope WorkerThread::postTask checks a flag of DevTools instrumentation, but this flag is set here only when it's called from WorkerOrWorkletGlobalScope::postTask. For cleanup, this CL moves the check from WorkerThread to WorkerOrWorkletGlobalScope. BUG= 625927 Review-Url: https://codereview.chromium.org/2640813006 Cr-Commit-Position: refs/heads/master@{#444688} [modify] https://crrev.com/e8a03e2020bf9aad333ae60eb57541e7eafb4f24/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/e8a03e2020bf9aad333ae60eb57541e7eafb4f24/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h [modify] https://crrev.com/e8a03e2020bf9aad333ae60eb57541e7eafb4f24/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/e8a03e2020bf9aad333ae60eb57541e7eafb4f24/third_party/WebKit/Source/core/workers/WorkerThread.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d377f2d2230bc9302eca1f725e919b3b6a4305f1 commit d377f2d2230bc9302eca1f725e919b3b6a4305f1 Author: nhiroki <nhiroki@chromium.org> Date: Thu Jan 19 14:41:11 2017 Worker: Stop accessing ExecutionContext passed by ExecutionContextTask This is a part of the project to deprecate ExecutionContextTask. InProcessWorkerMessaginProxy passes ExecutionContext to InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to deprecate ExecutionContextTask. The messaging proxy should pass it in a different way. After this CL, the messaging proxy passes a pointer to WorkerThread and the object proxy accesses ExecutionContext via WorkerThread. Consequently, ExecutionContext passed by ExecutionContextTask is no longer necessary. BUG= 625927 Review-Url: https://codereview.chromium.org/2639153004 Cr-Commit-Position: refs/heads/master@{#444729} [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp [modify] https://crrev.com/d377f2d2230bc9302eca1f725e919b3b6a4305f1/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f3cc31c4c860e5cad96ad142562cd714c0fcf47 commit 7f3cc31c4c860e5cad96ad142562cd714c0fcf47 Author: nhiroki <nhiroki@chromium.org> Date: Thu Jan 19 16:09:56 2017 Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope ExecutionContextTask is being deprecated. This CL replaces ExecutionContextTask use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with WTF::CrossThreadClosure. BUG= 625927 Review-Url: https://codereview.chromium.org/2645613006 Cr-Commit-Position: refs/heads/master@{#444751} [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/WorkerThread.h [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/7f3cc31c4c860e5cad96ad142562cd714c0fcf47/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06f260832ead33668b4fa5a64074fb8a158b127f commit 06f260832ead33668b4fa5a64074fb8a158b127f Author: nhiroki <nhiroki@chromium.org> Date: Fri Jan 20 10:15:53 2017 Worker: Reduce use of ExecutionContextTask in core/workers ExecutionContextTask is deprecated in favor of WTF::Closure. BUG= 625927 Review-Url: https://codereview.chromium.org/2642113002 Cr-Commit-Position: refs/heads/master@{#445028} [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkerThread.h [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/core/workers/WorkletGlobalScope.h [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/06f260832ead33668b4fa5a64074fb8a158b127f/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fbd15767912e9546dab933ba377c8ab68a5b3c8 commit 5fbd15767912e9546dab933ba377c8ab68a5b3c8 Author: yuryu <yuryu@chromium.org> Date: Fri Feb 10 06:34:45 2017 Reduce use of ExecutionContextTask in core/ ExecutionContextTask is deprecated in favor of WTF::Closure. This patch replaces ExecutionContextTask::postTask with WebTaskRunner::postTask in some of the occurrences. BUG= 625927 Review-Url: https://codereview.chromium.org/2680013008 Cr-Commit-Position: refs/heads/master@{#449557} [modify] https://crrev.com/5fbd15767912e9546dab933ba377c8ab68a5b3c8/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp [modify] https://crrev.com/5fbd15767912e9546dab933ba377c8ab68a5b3c8/third_party/WebKit/Source/core/fileapi/FileReader.cpp [modify] https://crrev.com/5fbd15767912e9546dab933ba377c8ab68a5b3c8/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c0fbcfa235ac535ef2b82690bb3619deee6b035 commit 0c0fbcfa235ac535ef2b82690bb3619deee6b035 Author: yuryu <yuryu@chromium.org> Date: Tue Feb 14 06:57:40 2017 Replace Document::postTask with WebTaskRunner::postTask Document::postTask is deprecated in favor of WebTaskRunner::postTask. This patch removes occurrences of postTask invocations from Document type instances. BUG= 625927 Review-Url: https://codereview.chromium.org/2688473005 Cr-Commit-Position: refs/heads/master@{#450283} [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/core/html/HTMLInputElement.cpp [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/web/ExternalPopupMenu.cpp [modify] https://crrev.com/0c0fbcfa235ac535ef2b82690bb3619deee6b035/third_party/WebKit/Source/web/PopupMenuImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b2bb377f6425e4504ee8b2265ffe9bda97e191d commit 6b2bb377f6425e4504ee8b2265ffe9bda97e191d Author: yuryu <yuryu@chromium.org> Date: Fri Feb 17 05:18:40 2017 Replace ExecutionContextTask with WTF::Closure in StorageErrorCallback ExecutionContextTask is deprecated and will be replaced with WTF::Closure. This patch replaces ExecutionContextTask and ExecutionContext::postTask in StorageErrorCallback to WTF::Closure and WebTaskRunner::postTask respectively. BUG= 625927 Review-Url: https://codereview.chromium.org/2700753002 Cr-Commit-Position: refs/heads/master@{#451230} [modify] https://crrev.com/6b2bb377f6425e4504ee8b2265ffe9bda97e191d/third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp [modify] https://crrev.com/6b2bb377f6425e4504ee8b2265ffe9bda97e191d/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp [modify] https://crrev.com/6b2bb377f6425e4504ee8b2265ffe9bda97e191d/third_party/WebKit/Source/modules/quota/StorageErrorCallback.cpp [modify] https://crrev.com/6b2bb377f6425e4504ee8b2265ffe9bda97e191d/third_party/WebKit/Source/modules/quota/StorageErrorCallback.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d20a4962d5ffabb59953294bb28c6c9799422a8 commit 9d20a4962d5ffabb59953294bb28c6c9799422a8 Author: yuryu <yuryu@chromium.org> Date: Fri Feb 17 08:27:05 2017 Reduce createSameThreadTask usage in modules/ ExecutionContextTask is deprecated and will be replaced with WTF::Closure. This patch replaces ExecutionContextTask::postTask with WebTaskRunner::postTask in some of its occurrences. BUG= 625927 Review-Url: https://codereview.chromium.org/2698153003 Cr-Commit-Position: refs/heads/master@{#451268} [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/notifications/Notification.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/sensor/Sensor.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/webdatabase/Database.cpp [modify] https://crrev.com/9d20a4962d5ffabb59953294bb28c6c9799422a8/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daa2a25d8775cf2c875984b38e455dd7fd480bc7 commit daa2a25d8775cf2c875984b38e455dd7fd480bc7 Author: yuryu <yuryu@chromium.org> Date: Mon Feb 20 13:51:10 2017 Pass ScriptState directly to TaskRunnerHelper::get() TaskRunnerHelper::get() has a overload taking ScriptState* instead of ExecutionContext*, so we should let it handle ScriptState* rather than getting ExecutionContext* from ScriptState* at callers. BUG= 625927 Review-Url: https://codereview.chromium.org/2701153002 Cr-Commit-Position: refs/heads/master@{#451618} [modify] https://crrev.com/daa2a25d8775cf2c875984b38e455dd7fd480bc7/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp [modify] https://crrev.com/daa2a25d8775cf2c875984b38e455dd7fd480bc7/third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp [modify] https://crrev.com/daa2a25d8775cf2c875984b38e455dd7fd480bc7/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd commit 2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd Author: kinuko <kinuko@chromium.org> Date: Thu Feb 23 11:14:07 2017 WorkerLoaderProxy: stop accessing cross-thread execution context * Removes ExecutionContextTask * Adds getLoadingExecutionContext() accessor to WorkerLoaderProxy{,Provider} * Stops accessing execution context in a cross-thread way We could possibly further clean up WorkerLoaderProxy, but I'll save it for later changes. BUG= 625927 , 673711 Review-Url: https://codereview.chromium.org/2709193002 Cr-Commit-Position: refs/heads/master@{#452458} [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.h [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/039895d69bd49f30bf762e7ab5c8812211998f16 commit 039895d69bd49f30bf762e7ab5c8812211998f16 Author: yuryu <yuryu@chromium.org> Date: Fri Mar 10 11:58:38 2017 Replace createCrossThreadTask with crossThreadBind in webaudio createCrossThreadTask and ExecutionContextTask are deprecated in favor of crossThreadBind and CrossThreadClosure respectively. This patch removes the deprecated versions. This patch also changes the code to post tasks to WebTaskRunner instead of ExecutionContext, but the behavour remains the same as Document::postTask already forwards tasks to WebTaskRunner of the LocalFrame in the Document. BUG= 625927 Review-Url: https://codereview.chromium.org/2738823004 Cr-Commit-Position: refs/heads/master@{#456042} [modify] https://crrev.com/039895d69bd49f30bf762e7ab5c8812211998f16/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp [modify] https://crrev.com/039895d69bd49f30bf762e7ab5c8812211998f16/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp [modify] https://crrev.com/039895d69bd49f30bf762e7ab5c8812211998f16/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp [modify] https://crrev.com/039895d69bd49f30bf762e7ab5c8812211998f16/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff80830195cffa6ffb66ccbef546ff4a0f758a5f commit ff80830195cffa6ffb66ccbef546ff4a0f758a5f Author: yuryu <yuryu@chromium.org> Date: Fri Mar 10 12:03:14 2017 Replace createCrossThreadTask with crossThreadBind in webdatabase createCrossThreadTask and ExecutionContextTask are deprecated in favor of crossThreadBind and CrossThreadClosure respectively. This patch removes the deprecated versions. This patch also changes the code to post tasks to WebTaskRunner instead of ExecutionContext, but the behavour remains the same as Document::postTask already forwards tasks to WebTaskRunner of the LocalFrame in the Document. BUG= 625927 Review-Url: https://codereview.chromium.org/2741443003 Cr-Commit-Position: refs/heads/master@{#456043} [modify] https://crrev.com/ff80830195cffa6ffb66ccbef546ff4a0f758a5f/third_party/WebKit/Source/modules/webdatabase/Database.cpp [modify] https://crrev.com/ff80830195cffa6ffb66ccbef546ff4a0f758a5f/third_party/WebKit/Source/modules/webdatabase/Database.h [modify] https://crrev.com/ff80830195cffa6ffb66ccbef546ff4a0f758a5f/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp [modify] https://crrev.com/ff80830195cffa6ffb66ccbef546ff4a0f758a5f/third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e533644399b42111d85ab607219494ed719f0cb commit 4e533644399b42111d85ab607219494ed719f0cb Author: yuryu <yuryu@chromium.org> Date: Mon Mar 13 08:36:15 2017 Replace WorkerGlobalScope::postTask with WorkerThread::postTask ExecutionContextTask and ExecutionContext::postTask are deprecated and will be removed. This patch changes WorkerEventQueue to post tasks directly through an underlying thread of WorkerGlobalScope as well as adding a single thread version of WorkerThread::postTask. The behavior remains the same. BUG= 625927 Review-Url: https://codereview.chromium.org/2741643003 Cr-Commit-Position: refs/heads/master@{#456337} [modify] https://crrev.com/4e533644399b42111d85ab607219494ed719f0cb/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp [modify] https://crrev.com/4e533644399b42111d85ab607219494ed719f0cb/third_party/WebKit/Source/core/workers/WorkerThread.cpp [modify] https://crrev.com/4e533644399b42111d85ab607219494ed719f0cb/third_party/WebKit/Source/core/workers/WorkerThread.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd45ce00fc6cf88a65b370c1a574e5b26319a40b commit cd45ce00fc6cf88a65b370c1a574e5b26319a40b Author: yuryu <yuryu@chromium.org> Date: Tue Mar 14 08:24:58 2017 Remove createSameThreadTask() and deprecate createCrossThreadTask() These functions and ExecutionContextTask are deprecated in favor of WTF::bind(), crossThreadBind(), and WTF::Closure and WTF::CrossThreadClosure respectively. This patch removes createSameThreadTask() and mark createCrossThreadTask() deprecated. It also removes unused ExecutionContextTask.h includes. BUG= 625927 Review-Url: https://codereview.chromium.org/2748953002 Cr-Commit-Position: refs/heads/master@{#456651} [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/core/dom/ExecutionContextTask.h [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp [modify] https://crrev.com/cd45ce00fc6cf88a65b370c1a574e5b26319a40b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b231885a172263ba6e862e22819a3221140656eb commit b231885a172263ba6e862e22819a3221140656eb Author: yuryu <yuryu@chromium.org> Date: Wed Mar 15 06:25:17 2017 Remove AUTOSIZING_DOM_DEBUG_INFO sections from TextAutosizer TextAutosizer has AUTOSIZING_DOM_DEBUG_INFO macros to conditionally compile, but it doesn't compile when defined. The macro is not documented or integrated to the build system. It uses deprecated ExecutionContextTask there so this patch removes this conditional macro. BUG= 625927 , 701283 Review-Url: https://codereview.chromium.org/2749773002 Cr-Commit-Position: refs/heads/master@{#457012} [modify] https://crrev.com/b231885a172263ba6e862e22819a3221140656eb/third_party/WebKit/Source/core/layout/TextAutosizer.cpp [modify] https://crrev.com/b231885a172263ba6e862e22819a3221140656eb/third_party/WebKit/Source/core/layout/TextAutosizer.h
yuryu@: I think the last blocker is gone ( issue 694925 ). Can you resume removing ExecutionContextTask?
thanks! I will send a patch for review shortly.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3 commit ae0b9e7f0d6fe6642fd504557d3780656fc49cd3 Author: yuryu <yuryu@chromium.org> Date: Tue Jun 06 07:04:12 2017 Remove deprecated ExecutionContextTask ExecutionContextTask has been deprecated and replaced with WTF::Closure. This patch removes the class and related methods, including ExecutionContext::postTask and overridden methods. BUG= 625927 Review-Url: https://codereview.chromium.org/2856773003 Cr-Commit-Position: refs/heads/master@{#477222} [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/dom/BUILD.gn [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/dom/Document.h [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/dom/ExecutionContext.cpp [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/dom/ExecutionContext.h [delete] https://crrev.com/44d1353d9f4b134e7aee2b1d70eae0e0320b42c7/third_party/WebKit/Source/core/dom/ExecutionContextTask.h [delete] https://crrev.com/44d1353d9f4b134e7aee2b1d70eae0e0320b42c7/third_party/WebKit/Source/core/dom/ExecutionContextTaskTest.cpp [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/testing/NullExecutionContext.cpp [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/testing/NullExecutionContext.h [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp [modify] https://crrev.com/ae0b9e7f0d6fe6642fd504557d3780656fc49cd3/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h
ExecutionContextTask is completely gone. Thank you, yuryu-san!! :D
Comment 1 by hirosh...@chromium.org
, Jul 6 2016