New issue
Advanced search Search tips

Issue 625924 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Autohide Shelf doesn't work for an app launched from overflow menu of Shelf

Project Member Reported by takaoka@chromium.org, Jul 6 2016

Issue description

Chrome Version: 51.0.2704.103, 53.0.2773.0 
Chrome OS Version: 8172.60.0, 8481.0.0
Chrome OS Platform: Pixel 2015

How to reproduce.
Preparation 1. Sets Shelf position to the left or right (not necessary but useful to create overflow in the next step)
Preparation 2. Pins a lot of apps to Shelf until overflow menu appears on Shelf.
Step 1. Enable Autohide shelf.
Step 2. Launch an app from overflow menu of Shelf (See 2nd screenshot).

Expected behavior:
After step 2, Shelf hides automatically and the app is maximized.

Observed behavior:
After step 2, The app is maximized but Shelf remains on the screen (See 3rd attached screenshot).

This issue happens only from overflow. Autohide Shelf works fine for an app on Shelf itself.
 
Screenshot 2016-07-06 at 15.14.05.png
5.9 MB View Download
Screenshot 2016-07-06 at 15.16.16.png
5.9 MB View Download
Screenshot 2016-07-06 at 15.17.17.png
2.1 MB View Download
Note that after step 3, the overflow menu remains on the screen as well. That should be dismissed automatically after the app is launched.

Comment 2 by dchan@google.com, Aug 8 2016

Components: Platform>Apps>ARC Platform>ARC
Note that this issue happens for all type of apps, not specific to ARC apps.
Cc: abod...@chromium.org abodenha@chromium.org dhadd...@chromium.org sdantul...@chromium.org
Components: -Platform>Apps>ARC -Platform>ARC UI>Shell>Shelf
Labels: M-58
Status: Untriaged (was: Unconfirmed)

Comment 5 by moch@chromium.org, Feb 28 2017

Owner: zork@chromium.org
Status: Assigned (was: Untriaged)
Owner: sammiequon@chromium.org
I can look at this one, Zach.
Cc: zork@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4242daf2b69dfc2c76b92adeeeb5d7efc756d59f

commit 4242daf2b69dfc2c76b92adeeeb5d7efc756d59f
Author: sammiequon <sammiequon@chromium.org>
Date: Fri Apr 07 15:42:47 2017

Shelf: Hide overflow bubble when app launched from overflow.

When the shelf is in autohide, the shelf does not hide after launching from overflow shelf. This is because the overflow shelf remains visible after lauching an app, which this CL fixes.

BUG= 625924 
TEST=manual,ash_unittests --gtest_filter="ShelfViewTest.*"

Review-Url: https://codereview.chromium.org/2807473003
Cr-Commit-Position: refs/heads/master@{#462869}

[modify] https://crrev.com/4242daf2b69dfc2c76b92adeeeb5d7efc756d59f/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/4242daf2b69dfc2c76b92adeeeb5d7efc756d59f/ash/shelf/shelf_view_unittest.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Chrome OS 9460.5.0/59.0.3071.15

Sign in to add a comment