New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625921 link

Starred by 2 users
Status: Fixed
Owner:
█ stip@chromium.org
gone, assign your bugs elsewhere :)
Closed: Jul 2016
Cc:
dpranke@chromium.org
jbudorick@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

remove_build_metadata not run on remote_device_dummy.apk

Project Member Reported by stip@chromium.org, Jul 6 2016 
remote_device_dummy.apk is included in many critical android targets. As it is in the out/*/apks/ folder (and not out/*/${APKNAME}_apk/), remove_build_metadata won't remove any nondeterminism in it. This means that most android targets are currently nondeterministic, and can't be deduped.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/29bcaa9f42c5be4dcd944144d50bcc2bb9212140

commit 29bcaa9f42c5be4dcd944144d50bcc2bb9212140
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 15:18:17 2016
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/6621e3f969b66d0a8b1b66f3595481557adcd49e

commit 6621e3f969b66d0a8b1b66f3595481557adcd49e
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 15:37:28 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cf1ef26b8334f62563e36511c643d1836767e137 Search in apks/ as well as *_apk/ for built apks. (stip@chromium.org)

R=stip@chromium.org
BUG= 625921 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2127903002

[modify] https://crrev.com/6621e3f969b66d0a8b1b66f3595481557adcd49e/infra/config/recipes.cfg
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5b8376e53b330fe36c1210df898030e0cc05c94f

commit 5b8376e53b330fe36c1210df898030e0cc05c94f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 20:07:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/938d099715b4ff6c88e8fc5d3a81cac5757f9b00 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/7e2069ad4011c6f8ca6989ea43e80c6921142385 V8: Remove gyp-flag-comparison feature after MB switch. (machenbach@chromium.org)
  https://crrev.com/6cd6eedf865126865cd6bf937f32f199dd0b8d03 V8: Add temporary bots to support gyp (machenbach@chromium.org)
  https://crrev.com/cf1ef26b8334f62563e36511c643d1836767e137 Search in apks/ as well as *_apk/ for built apks. (stip@chromium.org)
  https://crrev.com/74a4652c0bb9202b6b418789dae5df67555bd8bc Move known_devices file to ~/.android (bpastene@chromium.org)
depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)
  https://crrev.com/4d0545a43968c2cf1d03f03df368da05c94a4a6e Implement git cl upload --dry-run or --use-commit-queue for Gerrit. (tandrii@chromium.org)

R=bpastene@chromium.org,tandrii@chromium.org,machenbach@chromium.org,emso@chromium.org,stip@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:474921 , 625921 , 624502 , 622828 , 616035 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2128653002

[modify] https://crrev.com/5b8376e53b330fe36c1210df898030e0cc05c94f/infra/config/recipes.cfg
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/793d63ce81d40b0e542cc16839609b2fa2580a2f

commit 793d63ce81d40b0e542cc16839609b2fa2580a2f
Author: stip <stip@chromium.org>
Date: Wed Jul 06 21:54:10 2016

Revert of Search in apks/ as well as *_apk/ for built apks. (patchset #1 id:1 of https://codereview.chromium.org/2122063003/ )

Reason for revert:
Speculative revert to see if this fixes https://bugs.chromium.org/p/chromium/issues/detail?id=626042.

Original issue's description:
> Search in apks/ as well as *_apk/ for built apks.
>
> BUG= 625921 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/cf1ef26b8334f62563e36511c643d1836767e137

TBR=jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 625921 

Review-Url: https://codereview.chromium.org/2122233003

[modify] https://crrev.com/793d63ce81d40b0e542cc16839609b2fa2580a2f/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/69bcad05a91868ce49c89dd2c2e72f1fcb441d66

commit 69bcad05a91868ce49c89dd2c2e72f1fcb441d66
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 21:58:41 2016
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/9b38c5021819745086c45731712ef7e395040e44

commit 9b38c5021819745086c45731712ef7e395040e44
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 22:19:11 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/793d63ce81d40b0e542cc16839609b2fa2580a2f Revert of Search in apks/ as well as *_apk/ for built apks. (patchset #1 id:1 of https://codereview.chromium.org/2122063003/ ) (stip@chromium.org)

R=jbudorick@chromium.org,stip@chromium.org
BUG= 625921 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2124153002

[modify] https://crrev.com/9b38c5021819745086c45731712ef7e395040e44/infra/config/recipes.cfg

Comment 8 by benhenry@google.com, Jul 7 2016

Status: Assigned (was: Untriaged)

Comment 9 by benhenry@google.com, Jul 7 2016

Labels: Pri-1

Comment 10 by stip@chromium.org, Jul 28 2016

Status: Fixed (was: Assigned)
Closing in favor of https://bugs.chromium.org/p/chromium/issues/detail?id=630930.
►

Sign in to add a comment