New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Rebasline two canvas tests after minute differences due to Skia batching change.

Project Member Reported by bsalo...@google.com, Jul 6 2016

Issue description

These tests have very minor pixel differences after a change to Skia that increases draw batching:

virtual/gpu-rasterization/fast/images/color-profile-group.html
virtual/gpu/fast/canvas/image-object-in-canvas.html

Differences are here: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/87820/layout-test-results/results.html
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 6 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c51cfe07f95a31305fb25b9bcc6cf3fab50e432

commit 4c51cfe07f95a31305fb25b9bcc6cf3fab50e432
Author: bsalomon <bsalomon@google.com>
Date: Wed Jul 06 13:38:28 2016

Mark two canvas tests as needing rebaseline due to Skia change.

BUG= 625909 
TBR=fmalita@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2125763002
Cr-Commit-Position: refs/heads/master@{#403896}

[modify] https://crrev.com/4c51cfe07f95a31305fb25b9bcc6cf3fab50e432/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9858979e35f989d4418e4c392fbf60fdd6a14ad

commit e9858979e35f989d4418e4c392fbf60fdd6a14ad
Author: bsalomon <bsalomon@google.com>
Date: Wed Jul 06 17:34:42 2016

Autorebaseline tests affected by  crbug.com/625909 

BUG= 625909 

Review-Url: https://codereview.chromium.org/2129633002
Cr-Commit-Position: refs/heads/master@{#403926}

[modify] https://crrev.com/e9858979e35f989d4418e4c392fbf60fdd6a14ad/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7306e0a938b793153d8b8cb3d1e06d486d664ba

commit e7306e0a938b793153d8b8cb3d1e06d486d664ba
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Tue Jul 12 00:51:54 2016

Auto-rebaseline for r403926

https://chromium.googlesource.com/chromium/src/+/e9858979e

BUG= 625909 
TBR=bsalomon@google.com

Review URL: https://codereview.chromium.org/2139953002 .

Cr-Commit-Position: refs/heads/master@{#404758}

[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a58f3739d4f4c7bee66c35766892de03fe8d322d/third_party/WebKit/LayoutTests/platform/linux-precise/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/fast/images/color-profile-group-expected.png
[modify] https://crrev.com/e7306e0a938b793153d8b8cb3d1e06d486d664ba/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png

Comment 5 by bsalo...@google.com, Jul 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment