New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625904 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Feb 2018
Cc:
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Skia doesn't flatten a linear-gradient background with a border inside devtools

Reported by da...@davidjfox.com, Jul 5 2016 
UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2788.0 Safari/537.36

Steps to reproduce the problem:
Steps to reproduce the problem:
1. Go to the timeline tab in devtools and set it up to capture "Paint" events

2. Record the html file attached to this bug report

3. Stop recording when the page is done loading and view the Layer section in each of the frames (you may have to record a couple refreshes as well since the page loads so quickly)

4. See the bugged output

What is the expected behavior?

What went wrong?
The paints of in the layer view should result in expected.jpg not bugged.jpg

Did this work before? Yes 

Chrome version: 54.0.2788.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0

I've tracked the regression back to https://chromium.googlesource.com/skia/+/76be9c8dc0e5306ef81c2987848088cdec7ccd3f
bugged.png
12.4 KB View Download
expected.png
10.1 KB View Download
background-with-border-test.html
1.0 KB View Download

Comment 1 by ranjitkan@chromium.org, Jul 14 2016

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Windows 7 for chrome version 54.0.2794.0. Followed the steps as mentioned above. Attached a screen shot for the same:

david@: Request you to please try this again on an updated canary version and let us know with your observations.

Thanks.!
Paint view.png
56.9 KB View Download

Comment 2 by da...@davidjfox.com, Jul 14 2016 

I can confirm it still happens on the latest chromium build #405439. Not sure why you wouldn't be able to observe it...

Comment 3 by da...@davidjfox.com, Jul 14 2016 

Forgot to update here on the cause of this issue.

When we draw a background, we create a tile the size of the background-origin and tile it to fit background-clip if necessary.

By default their values are: background-origin: padding-box AND background-clip: border-box... Which means when we have a border, padding-box =/= border-box. Thus requiring tiling.

This is where the problem lies: We use SkPictureShaders to tile linear-gradients, which do not get serialized with the default security settings. Because of this, devtools cant replay SkPictureShaders.

Comment 4 by tkonch...@chromium.org, Jul 14 2016

Cc: tkonch...@chromium.org
Unable to reproduce the issue on Windows 8.1 for chrome version 54.0.2796.2 

Please find the screenshot

Could you please try the same on a new profile where there are no apps/extensions and update the thread. You can create a new profile from chrome://settings
625904.png
136 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 14 2016

Labels: -Needs-Feedback Needs-Review
Owner: ranjitkan@chromium.org
Thank you for providing more feedback. Adding requester "ranjitkan@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by da...@davidjfox.com, Jul 14 2016 

Ah now i know what the problem is. The problem is not in chrome rendering it, the problem is in devtools replaying it inside the layers panel. My picture must have confused you. This is what i am talking about:
updated-bugged.png
59.1 KB View Download

Comment 7 by da...@davidjfox.com, Jul 14 2016 

This is the slightly updated test I have been using as well (what you see in the picture):
background-with-border-test.html
1.5 KB View Download

Comment 8 by ranjitkan@chromium.org, Feb 27 2017

Labels: -Needs-Review
Owner: ----
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 27 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment