Stale .pyc files in webkitpy can lead to failures. |
|||||
Issue descriptionFor example, after http://crrev.com/2112133002, which removed a member of webkitpy.common.config.urls previously used by webkitpy.common.net.buildbot, running layout tests, caused an error: File "./third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 222, in BuildBot AttributeError: 'module' object has no attribute 'chromium_buildbot_url' This caused several people to see errors and waste some time -- bug 625594 and bug 625869 . Dirk noted in http://crrev.com/2112133002: > We have presubmit checks and hooks that clean up stale .pyc files in various places in the repo. We should check and make sure we have one for webkitpy as well.
,
Jul 5 2016
,
Jul 5 2016
This sounds like the kind of issues we should have avoided and we might want to find a fix ASAP. US folks coming back from their 4-day week-end might waste a lot of time trying to understand what's happening here.
,
Jul 5 2016
(sorry, didn't mean to remove xidachen@)
,
Jul 5 2016
"rm third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.pyc" seems to workaround this issue.
,
Jul 6 2016
https://cs.chromium.org/chromium/src/tools/remove_stale_pyc_files.py looks very relevant; it's currently only being used here: https://cs.chromium.org/chromium/src/DEPS?l=537
,
Jul 6 2016
FYI, I think this also breaks Tools/Scripts/lint-test-expectations which runs on presubmit if your patch includes a change to LayoutTests/TestExpectations.
,
Jul 7 2016
+1 developer bitten by this, who spent too much time discovering this bug.
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfda207ba80f0a5989c727e0b9ed08bb918db72f commit dfda207ba80f0a5989c727e0b9ed08bb918db72f Author: qyearsley <qyearsley@chromium.org> Date: Fri Jul 08 14:16:12 2016 Add hook to run remove_stale_pyc_files for WebKit/Tools/Scripts. I believe that this will clear unwanted pyc files when `gclient sync` is run, which may prevent people from hitting http://crbug.com/625877 . I tested this by adding a bogus pyc file to WebKit/Tools/Scripts and running gclient sync, which deleted it. BUG= 625877 Review-Url: https://codereview.chromium.org/2124273004 Cr-Commit-Position: refs/heads/master@{#404363} [modify] https://crrev.com/dfda207ba80f0a5989c727e0b9ed08bb918db72f/DEPS
,
Jul 12 2016
I believe that this is fixed now, assuming that people generally regularly run gclient sync; please re-open if it's still an issue.
,
Jul 12 2016
Yes, I can confirm that I had this issue until I synced past the the commit in #9 which fixed things. Thank you for the fix :) |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by qyears...@chromium.org
, Jul 5 2016