I've noticed this as well.

Cmd Shift F is tied to "Always Show Toolbar in Fullscreen". Full screen mode toggling is tied to Control Cmd F. I believe this is correct because it's the keyboard shortcut assigned in other Mac apps (Safari, TextEdit, etc.). I don't think anything has changed recently because these are the same keyboard shortcuts as in M51.

I'm pretty sure cmd-shift-f used to toggle it. At least around M48 or so.

I guess I'll just bisect.

Looks like in older versions, "Always Show Toolbar in Fullscreen" used to be "Enter Presentation Mode" and had the same shortcut. So the behavior of cmd-shift-f did indeed change, from actually toggling fullscreen (presentation mode) to toggling a preference without affecting your screen.

You are probably looking for a change made after 373669 (known good), but no later than 373709 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/b6bd151a94c2206449de57c6167c6bf17cc40b6f..58c0f982d2c8bef57b173e0f62748a9b8f722e2e


I guess it's this CL by spqchan@: https://chromium.googlesource.com/chromium/src/+/cae22576c51838b5c32a2d489e8c6187dc3c451f

Closing this because Presentation Mode no longer exists and has been replaced with 
"Always Show Toolbar in Fullscreen". This is expected behaviour

Sure, but the point is the shortcut to toggle a fullscreen mode was cmd-shift-f which no longer does that.

I understand that presentation mode is gone and replaced by a pref that controls full screen behavior, however I suspect a lot of users are used to using cmd-shift-f to actually enter a fullscreen mode.

The argument I guess is for users to re-train themselves to use control-shift-f?

(er control-cmd-f rather)

Unfortunately, this preference has been here for sometime (since M49) so I think a good amount of users has already re-trained themselves by now. At this point, switching Ctrl-Shift-F back to toggling fullscreen might make things even more confusing

Yeah, that's fair. I guess we also match current Safari, so there's a good argument for keeping as-is. (Although I find it a bit unfortunate - besides just being used to the old one, I find hitting ctrl-cmd-F being a bit more awkward from a finger dexterity point of view.)

> I guess I'll just bisect.

You beat me to it. Thank you for doing it.

The keyboard shortcut for the "Enter Full Screen" command on the Mac is Control Cmd F. We should adhere to that convention so that we behave the same as all the other apps on the platform.

Yep.

I just worry about people who're used to cmd-shift-f working and then it no longer does anything. For example, that's the boat I was in and just assumed its broken or some extension I have is messing with it - and then went to use the hotdog menu instead. (I didn't care enough at the time to investigate more deeply.)

I wonder how many users are in a similar boat. Not sure what a good solution is - short of showing some overlay (like the Quit one) when someone toggles the other option to indicate what's happening.

That is a good point - the silent failure is not great.

This change happened in M49 so it's been in place for almost 4 months - at least it doesn't appear that many users have complained about it. And Control Cmd F has always been the keyboard shortcut for "Enter Full Screen" mode so that at least has not changed.

I'm inclined to leave it as-is. Like shrike said, M49 was a while ago and we didn't see anything major in gCon feedback (cc'ing melody to make sure).