New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 626256



Sign in to add a comment

Large V8 traces causing OOM in memory benchmarks

Project Member Reported by u...@chromium.org, Jul 5 2016

Issue description

Tracing overhead for v8 events can be more than 100MB. This is a problem for low-memory devices which crash with OOM on memory benchmarks.

The three most frequent V8 events (V8.CompileCode, V8.CompileFullCode, and V8.ParseLazy) make up 2/3 of all events.

By moving these events from the default 'v8' category into a separate category (e.g. 'v8.compile') we could reduce memory overhead of V8 tracing by 2/3 for benchmarks that don't care about v8 compilation time.
 

Comment 1 by u...@chromium.org, Jul 5 2016

Jochen, Camillo, would you agree with the proposed solution: moving v8 compile and parse events into non-default v8 category?

If so, I'll upload CL that does it.
sgtm

Just make sure the existing telemetry tests don't break
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53450e52ffd2026c1af64b495ebd300069d8ec3e

commit 53450e52ffd2026c1af64b495ebd300069d8ec3e
Author: ulan <ulan@chromium.org>
Date: Wed Jul 06 16:35:04 2016

Prepare for moving V8 compile events to disabled-by-default v8.compile
category.

This adds v8.compile category to benchmarks that track executionMetric.

BUG= 625865 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2121263002
Cr-Commit-Position: refs/heads/master@{#403915}

[modify] https://crrev.com/53450e52ffd2026c1af64b495ebd300069d8ec3e/tools/perf/benchmarks/v8.py

Comment 5 by u...@chromium.org, Jul 7 2016

Blockedon: 626256

Comment 6 by u...@chromium.org, Jul 18 2016

Status: Fixed (was: Assigned)

Sign in to add a comment