New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625864 link

Starred by 1 user
Status: Fixed
Owner:
█ bzanotti@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Upstream ProfileOAuth2TokenServiceProviderImpl

Project Member Reported by bzanotti@chromium.org, Jul 5 2016 
ProfileOAuth2TokenServiceProviderImpl can be upstreamed. The remaining dependencies to internal code will be shifted to SigninErrorProvider.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6

commit 11cafd6fcfbb59ead0cdb7907660f9de3d7506f6
Author: bzanotti <bzanotti@chromium.org>
Date: Wed Jul 06 17:03:01 2016

Upstream ProfileOAuth2TokenServiceProviderImpl.

BUG= 625864 

Review-Url: https://codereview.chromium.org/2121083004
Cr-Commit-Position: refs/heads/master@{#403920}

[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/components/signin/ios/browser/fake_profile_oauth2_token_service_ios_delegate.h
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/components/signin/ios/browser/fake_profile_oauth2_token_service_ios_delegate.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate_unittest.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/chrome/browser/signin/oauth2_token_service_factory.mm
[add] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.h
[add] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/chrome/ios_chrome.gyp
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/public/provider/chrome/browser/chrome_browser_provider.h
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/public/provider/chrome/browser/chrome_browser_provider.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/public/provider/chrome/browser/signin/signin_error_provider.h
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/public/provider/chrome/browser/signin/signin_error_provider.mm
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/public/provider/chrome/browser/test_chrome_browser_provider.h
[modify] https://crrev.com/11cafd6fcfbb59ead0cdb7907660f9de3d7506f6/ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f73bddbf5c33f57f7175c4b6910a2822d4fd1618

commit f73bddbf5c33f57f7175c4b6910a2822d4fd1618
Author: bzanotti <bzanotti@google.com>
Date: Wed Jul 06 18:51:24 2016
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f73bddbf5c33f57f7175c4b6910a2822d4fd1618

commit f73bddbf5c33f57f7175c4b6910a2822d4fd1618
Author: bzanotti <bzanotti@google.com>
Date: Wed Jul 06 18:51:24 2016

Comment 4 by bzanotti@chromium.org, Jul 6 2016

Status: Fixed (was: Started)
►

Sign in to add a comment