New issue
Advanced search Search tips

Issue 625854 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update deprecation warning message for keyIdentifier

Project Member Reported by dtapu...@chromium.org, Jul 5 2016

Issue description

Since M53 is branched we didn't get  issue 607349  fixed in time.

Update keyIdentifier deprecation warning to change it to M54.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/914730efebf6de6519c88ae9277d06e732a24ad0

commit 914730efebf6de6519c88ae9277d06e732a24ad0
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Jul 05 19:36:41 2016

Move removing keyIdentifier to M54.

I didn't get the changes done in time and we will land it in m54. This
change is itended to update the mesage in M53 release.

BUG= 625854 

Review-Url: https://codereview.chromium.org/2125693002
Cr-Commit-Position: refs/heads/master@{#403815}

[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/arrow-keys-on-body-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/init-events-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/js-keyboard-event-creation-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/fast/events/special-key-events-in-input-text-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-expected.txt
[modify] https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0/third_party/WebKit/Source/core/frame/Deprecation.cpp

Labels: Merge-Request-53
Labels: -Merge-Request-53
Labels: Merge-Request-53

Comment 5 by dimu@google.com, Jul 6 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e06c0c15bf641a994fd0da9f91591e1452af8600

commit e06c0c15bf641a994fd0da9f91591e1452af8600
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Jul 06 18:42:52 2016

Move removing keyIdentifier to M54.

I didn't get the changes done in time and we will land it in m54. This
change is itended to update the mesage in M53 release.

BUG= 625854 

Review-Url: https://codereview.chromium.org/2125693002
Cr-Commit-Position: refs/heads/master@{#403815}
(cherry picked from commit 914730efebf6de6519c88ae9277d06e732a24ad0)

Review URL: https://codereview.chromium.org/2130503002 .

Cr-Commit-Position: refs/branch-heads/2785@{#34}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/arrow-keys-on-body-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/init-events-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/js-keyboard-event-creation-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-button-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/key-events-in-input-text-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/fast/events/special-key-events-in-input-text-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchKeyEvent-expected.txt
[modify] https://crrev.com/e06c0c15bf641a994fd0da9f91591e1452af8600/third_party/WebKit/Source/core/frame/Deprecation.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment