[memory-metric] Exclude initial memory dumps without V8 from values reported in V8 benchmarks |
||
Issue description
The memory metric treats missing memory allocator dumps as zeros. As a
result, the reported values satisfy the following property:
average total size = total of averages of components (V8, Blink, ...)
Unfortunately, this causes noisiness in V8 benchmarks because the number
of dumps that are taken before V8 initialization is non-deterministic.
To address this, we'll do the following:
1. petrcermak@ adds support for the third optional rangeOfInterest
parameter to memoryMetric (see
https://codereview.chromium.org/2052593005/).
2. ulan@ modifies the V8 metric to calculate the range of memory dumps
that contain V8 and passes it to the memory metric.
,
Jul 8 2016
Ulan: You now need to define a 'v8MemoryMetric' that calls the memory metric with a modified range of interest:
function v8MemoryMetric(values, model) {
var range = tr.b.Range.fromExplicitRange(firstGlobalMemoryDumpWithV8.start, lastGlobalMemoryDump.end);
return memoryMetric(values, model, {rangeOfInterest: range});
}
,
Jul 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cffff985306c9404f210edc29480305bbc3234c2 commit cffff985306c9404f210edc29480305bbc3234c2 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Sat Jul 09 19:10:26 2016 Roll src/third_party/catapult/ 243e3dfbc..6cad5da3c (12 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/243e3dfbc911..6cad5da3c39e $ git log 243e3dfbc..6cad5da3c --date=short --no-merges --format='%ad %ae %s' BUG= 625363 ,531641,472699, 623058 ,472699, 625852 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2136803002 Cr-Commit-Position: refs/heads/master@{#404566} [modify] https://crrev.com/cffff985306c9404f210edc29480305bbc3234c2/DEPS
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f04d86267fdbb9b0a9b7cda9841f7f7126ef0ef commit 6f04d86267fdbb9b0a9b7cda9841f7f7126ef0ef Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Wed Jul 13 02:19:51 2016 Roll src/third_party/catapult/ 4160831d2..72fb0b506 (24 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4160831d2082..72fb0b5062af $ git log 4160831d2..72fb0b506 --date=short --no-merges --format='%ad %ae %s' BUG= 605842 ,531641, 605842 ,450171,589726, 627221 , 625852 ,589726, 622290 ,589726 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2147823002 Cr-Commit-Position: refs/heads/master@{#404903} [modify] https://crrev.com/6f04d86267fdbb9b0a9b7cda9841f7f7126ef0ef/DEPS
,
Jul 13 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by petrcermak@chromium.org
, Jul 8 2016Owner: u...@chromium.org
Status: Assigned (was: Untriaged)