New issue
Advanced search Search tips

Issue 625844 link

Starred by 2 users
Status: Fixed
Owner:
nzolghadr@chromium.org
Closed: Oct 2016
Cc:
mustaq@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 625843


Sign in to add a comment

Make pointerevents causing the dispatching of mouse events

Project Member Reported by nzolghadr@chromium.org, Jul 5 2016 
Right now we fire MouseEvent independent from PointerEvents. 
We need to make use of PlatformPointerEvent and PointerEvent and create the MouseEvent from those and dispatch mouse events accordingly.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c156f720034dbc6d6c29fd0409c01dda73ccb8f

commit 4c156f720034dbc6d6c29fd0409c01dda73ccb8f
Author: nzolghadr <nzolghadr@chromium.org>
Date: Tue Oct 04 14:15:20 2016

Extract more of the mouse logic from EventHandler

Extract the mouse logic to the extent that
GestureManager can use solely MouseEventManager
instead of being friend with EventHandler and use
private functions. Also this refactoring cleaned
up some parameter passing from EventHandler to
MouseEventManager that was going through
PointerEventManager functions.

Initial refactoring

BUG= 625844 

Review-Url: https://codereview.chromium.org/2350433002
Cr-Commit-Position: refs/heads/master@{#422781}

[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/EventHandlingUtil.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/EventHandlingUtil.h
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/GestureManager.h
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/MouseEventManager.h
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/PointerEventManager.h
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/4c156f720034dbc6d6c29fd0409c01dda73ccb8f/third_party/WebKit/Source/core/input/TouchEventManager.cpp

Comment 2 by nzolghadr@chromium.org, Oct 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment