Incorrect focus is seen in omnibox on pressing Tab key.
Reported by
vvishwak...@etouch.net,
Jul 5 2016
|
||||||||||||
Issue descriptionVersion: 54.0.2788.0 (Official Build) 503e06926312c99e6fe02e0d1a41c19eb6a06c9d-refs/heads/master@{#403706} (64-bit) OS: Mac (10.10.5, 10.11.4) What steps will reproduce the problem? 1) Launch chrome, go to chrome://settings and click in omnibox. 2) Press Tab key and observe the focus. On pressing Tab key focus is on 'View site info' button. On pressing Tab key focus should be on bookmark (Star) button. This is a Non-Regression issue seen from M-53 series (Chrome version: 53.0.2780.0) Note: Issue is not seen on Windows and Linux OS.
,
Jul 8 2016
In the new chrome settings page, focus skips both of those buttons entirely. On the old settings page, everything seems to work fine.
,
Jul 8 2016
Note that the video shows that Tab brings focus to "View Site Info" on the old settings page. It also does this on all other pages. This doesn't seem like an issue to me, since the next press of tab brings focus to the star.
,
Jul 8 2016
Ugggh now that I look at this more, this has nothing to do with WebUI settings. All pages exhibit this behavior on one of my devices, but not on the other. Definitely omnibox related. Assigning to shrike, who likely knows more about the new omnibox.
,
Jul 8 2016
ellyjones@ recently added Omnibox decorations to the focus loop. I'm not sure if the first tab press should focus the bookmark star or the site info button - we should do whatever Windows does.
,
Jul 8 2016
btw, this might(?) depend on whether you've enabled Mac OS X to add "All controls" to your tab order http://www.webassign.net/manual/student_guide/t_a_osx_tab_config.htm
,
Jul 19 2016
In response to c#5, the answer is focus order follows visual order.
,
Jul 20 2016
I landed a change that makes those elements un-focusable for the moment; I will land another one later that fixes the focus order properly.
,
Feb 2 2017
Just checking in to see how this work is coming along. Thanks, Elly!
,
Feb 3 2017
+cc sdy@ for comment #9: Stuck, basically. We've thought of some clever ways to achieve the desired goal but I think this is conceptually blocked on sdy@'s work to enable autolayout in the browser now. :(
,
Feb 3 2017
How does autolayout play into fixing this problem?
,
Feb 3 2017
I don't *think* my last idea depended on Auto Layout, but LMK.
,
Jun 16 2017
tickling this bug because it looks like the last person who commented (sdy@) was asking for input: > I don't *think* my last idea depended on Auto Layout, but LMK. also tickling it because I don't know the status of autolayout. Dropping to P-3 because this bug is old enough that clearly the fix isn't desired in a particular release.
,
Jun 19 2017
We fixed this a couple of months ago, in https://codereview.chromium.org/2839893003 |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 5 2016