New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625805 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Option overlay is not opened completely within the Card on ‘chrome://md-settings/siteSettings'

Reported by dmascare...@etouch.net, Jul 5 2016

Issue description

Chrome Version:53.0.2785.6 (Official Build) dc1090fa0edd6091d6d99381c7ec40115c60327d-refs/branch-heads/2785@{#15} (32/64-bit)
OS: Windows (7,8,8.1,10), Linux(14.04 LTS) and Mac(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/siteSettings/microphone
2. Click on ‘Add site exception’ such that overlay gets open and add some data,then click on ‘Add’ button.
3. Click on iron icon and observe option overlay.

Actual: Option overlay is not opened completely within the Card.(i.e. Some part of option overlay is seen outside the Card)
Expected: Option overlay should get opened within the Card.

This is non-regression issue, seen from ‘M 53’ ( 53.0.2751.0 )

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/eaba8a8909776cea5e0dc5203ec2d04316b3a5d5..f719daba1bae9dedfdd82cbfa06564ac6d78e4da?pretty=fuller&n=100

Suspecting: r396349 ?

@finnur- Please take a look.
 
Actual_ss.png
24.5 KB View Download
Exp_ss.png
107 KB View Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows, Mac and Linux. Changing the status to Untriaged so that the issue could get addressed.
Thank You.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: finnur@chromium.org
Status: Started (was: Untriaged)
This is a one-liner fix that is already in the works.
Labels: Proj-MaterialDesign-WebUI
Labels: -M-54 -MovedFrom-53 Hotlist-MD-Settings-Privacy-SiteSettings
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/734a31f5d5cce5cf938445d7c1795dcddc8c69ca

commit 734a31f5d5cce5cf938445d7c1795dcddc8c69ca
Author: finnur <finnur@chromium.org>
Date: Tue Aug 23 14:05:01 2016

Site Settings Desktop: Show menu right-aligned.

BUG= 625805 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2124783002
Cr-Commit-Position: refs/heads/master@{#413728}

[modify] https://crrev.com/734a31f5d5cce5cf938445d7c1795dcddc8c69ca/chrome/browser/resources/settings/site_settings/site_list.html

Comment 7 by finnur@chromium.org, Aug 23 2016

This last checkin fixes this problem but only for LTR languages (such as English).

Polymer seems to ignore this directional directive for RTL languages, so the problem may still occur there.

I'm hoping at some point Polymer just flips the direction automatically for RTL languages, but this will need to be verified at a later date. Leaving the bug open until then.

Comment 8 by finnur@chromium.org, Aug 23 2016

Status: Assigned (was: Started)
Status: Started (was: Assigned)
Switching out the control, which seems to fix this also.
Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f6bea6b3b13dc044d18813348c1137d0d0b51bc

commit 0f6bea6b3b13dc044d18813348c1137d0d0b51bc
Author: finnur <finnur@chromium.org>
Date: Wed Oct 05 18:27:18 2016

Site Settings Desktop: Switch out Site-List paper-menu for iron-dropdown.

BUG= 629920 ,  625805 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2386993005
Cr-Commit-Position: refs/heads/master@{#423228}

[modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/0f6bea6b3b13dc044d18813348c1137d0d0b51bc/chrome/test/data/webui/settings/site_list_tests.js

Comment 13 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment