Unnecessary quote appears after clicking on indent more option in compose box.
Reported by
vku...@etouch.net,
Jul 5 2016
|
|||||
Issue descriptionChrome Version:53.0.2785.6 (Official Build)Revision dc1090fa0edd6091d6d99381c7ec40115c60327d-refs/branch-heads/2785@{#15} (32/64-bit) OS:Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS). What steps will reproduce the problem? (1)Launch chrome and navigate to gmail.com ,login with valid credentials (2)Click on Compose button ,click on 'editable' text content area and click on 'quote' button. (3)Click on 'indent more' button and observe the cursor. Actual:Unnecessary quote appears after clicking on indent more option in compose box. Expected:Quote should not appear after clicking on indent more option in compose box. This is a Non-regression issue seen from 'M30' series (Chrome version: 30.0.1549.0) Note: Issue not seen on other browsers like firefox,I.E and Safari.
,
Jul 6 2016
Maybe Editing, but it might be a bug in gmail.
,
Jul 7 2016
All browsers do differently. But, Edge's behavior is intuitive for me. But, there are no spec for "Indent" command, I can't say which is valid.
,
Jul 21 2016
Here is a DOM state when we only add a blockquote. <div contenteditable><blockquote>|<br></blockquote></div> After indenting the blockquote, the change is as follows: <div contenteditable><blockquote><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"><blockquote>|<br></blockquote></blockquote></blockquote></div> We see an unnecessary blockquote. Instead, the result should be as follows: <div contenteditable><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"><blockquote>|<br></blockquote></blockquote></div> This CL could fix this problem: https://codereview.chromium.org/2175433002/
,
Jul 22 2016
yosin@ is a virtual owner. joone.hur@ is working now.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b844ddd6c6b82784257c183e50244eff895bce09 commit b844ddd6c6b82784257c183e50244eff895bce09 Author: joone.hur <joone.hur@intel.com> Date: Fri Jul 22 07:14:42 2016 Remove the unnecessary blockquote after indenting an empty blockquote Here is a DOM state when we only add a blockquote. <div contenteditable><blockquote>|<br></blockquote></div> After indenting the blockquote, the change is as follows: <div contenteditable> <blockquote> <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"> <blockquote>|<br></blockquote> </blockquote> </blockquote> </div> There is an unnecessary blockquote so the result should be as follows: <div contenteditable> <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"> <blockquote>|<br></blockquote> </blockquote> </div> This CL removes the additional blockquote. BUG= 625802 TEST=editing/execCommand/indent-empty-quote.html Review-Url: https://codereview.chromium.org/2175433002 Cr-Commit-Position: refs/heads/master@{#407091} [add] https://crrev.com/b844ddd6c6b82784257c183e50244eff895bce09/third_party/WebKit/LayoutTests/editing/execCommand/indent/indent_empty_quote.html [modify] https://crrev.com/b844ddd6c6b82784257c183e50244eff895bce09/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
,
Oct 19 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msrchandra@chromium.org
, Jul 5 2016