New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625798 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ServiceWorker BackgroundSync doesn't work when Dev Tools "offline" throttling is enabled

Reported by deanh...@gmail.com, Jul 5 2016

Issue description

Chrome Version       : 51.0.2704.103
URLs (if applicable) : https://deanhume.github.io/Service-Workers-BackgroundSync/

What steps will reproduce the problem?
(1) Open Chrome Developer Tools
(2) Navigate to the URL provided above and click button to make network request
(3) Navigate to the Network Tab and enable network throttling set to "Offline"
(4) Click button again to make network request

What is the expected result?
No network request should take place as I am technically offline. The Service Worker BackgroundSync functionality should kick in and wait until I am online again and then send the request. This works perfectly if I "properly" disconnect from the network and reconnect. It's just not working in Chrome Dev Tools.


What happens instead?
The request is made as normal and not queued for the Sync event.

 
Components: Platform>DevTools>Network

Comment 2 by allada@chromium.org, Jul 11 2016

Labels: -Pri-3 Pri-2
Owner: allada@chromium.org
Status: Assigned (was: Unconfirmed)
Owner: eostroukhov@chromium.org
Cc: eostroukhov@chromium.org
 Issue 697013  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8035134295d920636441e8f3b36c7b790c4545b4

commit 8035134295d920636441e8f3b36c7b790c4545b4
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Sat Apr 14 01:09:30 2018

DevTools: emulate offline mode for SW sync API

This change introduces a way for the DevTools to emulate offline mode
for the service worker background sync API. Notifications are queued up
and dispatched once the service worker comes online.

Bug:  625798 
Change-Id: Ie804b3699991b9b4cbc7035be8e1f3e03fb39596
Reviewed-on: https://chromium-review.googlesource.com/956099
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550844}
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/devtools/service_worker_devtools_agent_host.h

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8035134295d920636441e8f3b36c7b790c4545b4

commit 8035134295d920636441e8f3b36c7b790c4545b4
Author: Eugene Ostroukhov <eostroukhov@chromium.org>
Date: Sat Apr 14 01:09:30 2018

DevTools: emulate offline mode for SW sync API

This change introduces a way for the DevTools to emulate offline mode
for the service worker background sync API. Notifications are queued up
and dispatched once the service worker comes online.

Bug:  625798 
Change-Id: Ie804b3699991b9b4cbc7035be8e1f3e03fb39596
Reviewed-on: https://chromium-review.googlesource.com/956099
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550844}
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/8035134295d920636441e8f3b36c7b790c4545b4/content/browser/devtools/service_worker_devtools_agent_host.h

Sign in to add a comment