It may be a good idea to change from a single TextView that we format to '<publisher> - <timestamp>' to three separate TextViews. This would let Android take care of the ellipsis' and simplify a few other special cases (eg when the publisher is in a LTR language but the device is RTL).

Do make sure you test with an RTL layout.

Propose to Rachel if we could right align the publisher date as this will massively simplify the code and remove the need for java to manipulate and pre render to measure if there is space

@mvanouwerkerk: What's the latest status here? Was this ever fixed? Or is it obsolete (I didn't check what the current behavior is)?

I looked into it with Nicole when she was working on this. I think we could fix this by subclassing a LinearLayout or something like that, but she wasn't very keen on that. That's the latest. I have never seen this problem with production data, it's just something that came up with artificially long strings. P3 seems about right.

ok. sgtm.

What currently happens when we have a long publisher name?

Ah, scratch that - I see this noted at the top of the bug.

This is pretty non-ideal. Do we have an idea of how often it happens?

I've never seen this in the real world - it was just an edge case I thought of while making tests.

Deleted: long-publisher.png 22.1 KB

	long-publisher.png 22.1 KB View Download

OK, thanks Pete. P3 seems good then.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1611b2644697ca7bc868e9a68bf28dd15619d250

commit 1611b2644697ca7bc868e9a68bf28dd15619d250
Author: galinap <galinap@google.com>
Date: Wed Apr 19 12:43:40 2017

Fixed ellipsize of publisher instead of timespan string.

Screenshots here:
https://drive.google.com/drive/folders/0B7eRCSITD4qmYl9MbDRWWFFBZGs?usp=sharing

BUG= 625775 

Review-Url: https://codereview.chromium.org/2808773002
Cr-Commit-Position: refs/heads/master@{#465564}

[modify] https://crrev.com/1611b2644697ca7bc868e9a68bf28dd15619d250/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/1611b2644697ca7bc868e9a68bf28dd15619d250/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java