Issue metadata
Sign in to add a comment
|
Regression:Profile icon appears chopped after sign in to chrome://md-settings
Reported by
vku...@etouch.net,
Jul 5 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:53.0.2785.6 (Official Build)dc1090fa0edd6091d6d99381c7ec40115c60327d-refs/branch-heads/2785@{#15} (32/64 Bit) OS:Windows(7,8,10), Mac(10.10.5, 10.11.4) Precondition: Login with account which has dark profile icon. What steps will reproduce the problem? (1)Launch chrome and navigate to chrome://md-settings (2)Click on 'sign in to chrome' button and login (3)Observe the profile icon. Actual: Profile icon appears chopped after sign in to chrome://md-settings Expected: Profile icon should be completely visible after sign in to chrome://md-settings This is a regression issue broken in 'M53' and will soon update other info.
,
Jul 5 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Jul 12 2016
@dschuyler: Friendly Ping!
,
Jul 18 2016
Not a blocker issue, since feature is still under development. Removing blocker label, please add again if not the case. Thanks.!
,
Jul 18 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 9 2016
I was able to repro this using the default, blue profile generic person icon. In that case, the icon misrepresents its size, so there is transparency on the right edge.
,
Sep 9 2016
,
Sep 16 2016
More details:
The avatar icons are 38px wide by 31px high rectangles. We are using the 'cover' attribute to ask that the image cover the 40px by 40px square that we render into. The math doesn't quite work out and the image appears to be clipped off on the right hand edge.
If the icons are/were square, they cover the square well. It looks like noms@ tried making the icons square about two years ago:
https://codereview.chromium.org/225813006/
and then ended up reverting that change (so they are rectangular now):
https://codereview.chromium.org/266713011
,
Dec 9 2016
Issue still reproduced on latest stable 55.0.2883.75,Dev 56.0.2924.21 and Canary 57.0.2946.0.
,
Jan 6 2017
,
Mar 17 2017
@dschuyler any thoughts on this? It's still a stable blocker.
,
Mar 17 2017
tbuckly@ yes, as mentioned in comment #9. The source icons are incorrect. So, we need to either change the source icons or add special casing (hacks) to adjust to our internal icons on the fly. At one point (year+ ago) the icons were corrected and then that fix to those icons was reverts; I asked noms@ about it and they don't recall the details of why. And I should have unmarked the started status, so I'll do that now.
,
Mar 21 2017
,
Mar 22 2017
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5d274510522f75f93dfb4c79de24e1a6d301203 commit d5d274510522f75f93dfb4c79de24e1a6d301203 Author: dschuyler <dschuyler@chromium.org> Date: Wed Mar 22 19:41:41 2017 [MD settings] border radius to clip path on avatar icon This CL changes the way the avatar icon is clipped so that it doesn't appear to be cut off on the right edge. BUG= 625773 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2769493002 Cr-Commit-Position: refs/heads/master@{#458845} [modify] https://crrev.com/d5d274510522f75f93dfb4c79de24e1a6d301203/chrome/browser/ui/webui/settings/profile_info_handler.cc
,
Mar 22 2017
,
Mar 28 2017
Tested the issue on Latest Dev# 59.0.3053.3 on Windows and Mac and found the issue to be fixed. Profile icon is not being chopped after successful sign in. Hence adding TE-Verified Labels. Thank You. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Jul 5 2016Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
74.7 KB
74.7 KB View Download