New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625757 link

Starred by 3 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Hover effect is not seen after hovering a mouse pointer on vertical scroll bar in chrome://extensions.

Reported by yfulgaon...@etouch.net, Jul 5 2016 
Chrome version : 53.0.2785.4 6dfaf57f2779c1591d26fe68632c0fd6a4457a4a-refs/branch-heads/2785@{#7} (32/64 bit)
OS :  Windows (7,8,8.1,10), Linux(14.04 LTS) and Mac(10.10.5, 10.11.4)

What steps will reproduce the problem?
1) Launch chrome, go to chrome://extensions and add 4-5 extensions such that vertical scroll bar is seen at RHS.
2) Hover mouse on vertical scroll bar and observe.

Actual : Hover effect is not seen after hovering a mouse pointer on vertical scroll bar.
Expected : Hover effect should be seen after hovering a mouse pointer on vertical scroll bar.

This is a regression issue broken in 'M-49', below is the Manual regression and Narrow Bisect info:
Good Build : 49.0.2565.0
Bad Build : 49.0.2568.0

Narrow Bisect :
https://chromium.googlesource.com/chromium/src/+log/74fce33853729f49a3574a930862aeed91274b09..9f9a2c5916c15d252f5f1f6429d377835720b025?pretty=fuller&n=10000

Suspecting : r360144 from Narrow Bisect.
Actual_scrollbar.mp4
1.5 MB View Download
Expected_scrollbar.mp4
632 KB View Download

Comment 1 by wangxianzhu@chromium.org, Jul 11 2016 

Reduced test case:

<!DOCTYPE html>
<iframe srcdoc="<div style='height: 4000px'></div>"></iframe>

That is, scrollbar status of the iframe on mouse events are not updated.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e

commit d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Jul 13 03:26:12 2016

Fix under-invalidation of frame scrollbar on hover

Ensure the layoutView() of the frame is setMayNeedPaintInvalidation()
when the scrollbar needs paint invalidation.

BTW, combine PaintInvalidationCapableScrollableArea::
boxForScrollControlPaintInvalidation() and ScrollbarArea::layoutBox()
which was added recently.

BUG= 625757 
TEST=paint/invalidation/iframe-scrollbar-hover.html

Review-Url: https://codereview.chromium.org/2136133002
Cr-Commit-Position: refs/heads/master@{#404958}

[add] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover-expected.txt
[add] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Comment 3 by wangxianzhu@chromium.org, Jul 13 2016

Labels: -M-54 Merge-Request-53 M-53
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e

commit d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Jul 13 03:26:12 2016

Fix under-invalidation of frame scrollbar on hover

Ensure the layoutView() of the frame is setMayNeedPaintInvalidation()
when the scrollbar needs paint invalidation.

BTW, combine PaintInvalidationCapableScrollableArea::
boxForScrollControlPaintInvalidation() and ScrollbarArea::layoutBox()
which was added recently.

BUG= 625757 
TEST=paint/invalidation/iframe-scrollbar-hover.html

Review-Url: https://codereview.chromium.org/2136133002
Cr-Commit-Position: refs/heads/master@{#404958}

[add] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover-expected.txt
[add] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/d88ee7c4ceeb1ade22e8525fdef60115fae7ae3e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Comment 5 by dimu@google.com, Jul 14 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.

Comment 6 by gov...@chromium.org, Jul 14 2016 

Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary and safe to merge?

Comment 7 by wangxianzhu@chromium.org, Jul 14 2016 

Confirmed.

Comment 8 by gov...@chromium.org, Jul 14 2016

Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #7. Please merge ASAP. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 14 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de3230942b475204c9b07192f9f5d13af33e8d30

commit de3230942b475204c9b07192f9f5d13af33e8d30
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jul 14 19:00:20 2016

Fix under-invalidation of frame scrollbar on hover

Ensure the layoutView() of the frame is setMayNeedPaintInvalidation()
when the scrollbar needs paint invalidation.

BUG= 625757 
TEST=paint/invalidation/iframe-scrollbar-hover.html

Review URL: https://codereview.chromium.org/2153533002 .

Review-Url: https://codereview.chromium.org/2136133002
Cr-Original-Commit-Position: refs/heads/master@{#404958}
Cr-Commit-Position: refs/branch-heads/2785@{#123}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[add] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover-expected.txt
[add] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/LayoutTests/paint/invalidation/iframe-scrollbar-hover.html
[modify] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp
[modify] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h
[modify] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/de3230942b475204c9b07192f9f5d13af33e8d30/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Comment 10 by ssamanoori@chromium.org, Jul 19 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2785.21
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 53.0.2785.21.Observed that Hover effect is seen after hovering a mouse pointer on vertical scroll bar.

Marking it as TE-Verified.

Comment 11 by wangxianzhu@chromium.org, Jul 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment