textarea with dir="auto" and one character in Hebrew crashes the tab when navigating with left/right arrows
Reported by
pinto....@gmail.com,
Jul 5 2016
|
||||||||||||||||||
Issue descriptionChrome Version : Version 51.0.2704.103 m URLs (if applicable) : http://codepen.io/avipinto/pen/kXwBWq Other browsers tested: also happens in canary and an electron based app Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: Firefox:OK IE:OK What steps will reproduce the problem? (1) have a textarea with dir="auto" (2a) add a placeholder to the textarea and one character in Hebrew (like "ע") (2b) enter a string to the textarea containing one Hebrew letter and one or more english letters (like: "גf","aaaעbbb") (3) focus on the textarea and hit the right/left arrows to navigate the text What is the expected result? i would expect that the cursor will move along the text What happens instead? chrome hangs forever (25% CPU) seems like there is an infinite loop for determining the cursor position another problem is that when you enter several letters in Hebrew, the cursor can't be at the last position - hit End and the cursor will jump to the beginning of the text Please provide any additional information below. Attach a screenshot if possible. you can play with a reduced example here http://codepen.io/avipinto/pen/kXwBWq
,
Jul 6 2016
to be more specific, only the left arrow key(keyCode=37) causes the crash
,
Jul 12 2016
==================================== Good Build: 49.0.2567.0 Base Position: 360248 Bad Build: 49.0.2590.0 Base Position: 364940 ===================================== Able to repro this issue on Windows 7, MAC (10.11.5) & Ubuntu Trusty (14.04) for the Google Chrome Stable Version - 51.0.2704.106 This is a regression issue broken in M49, below mentioned is the bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/2ff76a86882308a81d17ac8bbeb57a95c3578a3e..98a0970e6672c6a0638f3d7c72ac4b5edf3aefe2 Suspecting Commit: 283fc78866474faf6b53203f2ba685ed0c33bef4 Review URL: https://codereview.chromium.org/1478573002 @tkent: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner. Thank you.
,
Jul 13 2016
Infinite loop in VisibleUnits.cpp leftVisuallyDistinctCandidate().
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55f27bb5c4f4f99a2885dc67bd6e448a464505ed commit 55f27bb5c4f4f99a2885dc67bd6e448a464505ed Author: tkent <tkent@chromium.org> Date: Wed Jul 13 07:29:15 2016 Placeholder content direction should not affect INPUT/TEXTAREA direction. Skip -webkit-input-placeholder elements when we compute direction for dir=auto in HTMLElement::directionality. - Using <bdi> for placeholders doesn't work. We want to inherit placeholder direction from the parent element. - Using unicode-bidi CSS property doesn't work. It doesn't affect dir=auto computation. BUG= 623270 , 625739 Review-Url: https://codereview.chromium.org/2145823003 Cr-Commit-Position: refs/heads/master@{#405069} [add] https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed/third_party/WebKit/LayoutTests/fast/forms/text/text-dir-auto-with-placeholder.html [add] https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html [modify] https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed/third_party/WebKit/Source/core/html/HTMLElement.cpp
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55f27bb5c4f4f99a2885dc67bd6e448a464505ed commit 55f27bb5c4f4f99a2885dc67bd6e448a464505ed Author: tkent <tkent@chromium.org> Date: Wed Jul 13 07:29:15 2016 Placeholder content direction should not affect INPUT/TEXTAREA direction. Skip -webkit-input-placeholder elements when we compute direction for dir=auto in HTMLElement::directionality. - Using <bdi> for placeholders doesn't work. We want to inherit placeholder direction from the parent element. - Using unicode-bidi CSS property doesn't work. It doesn't affect dir=auto computation. BUG= 623270 , 625739 Review-Url: https://codereview.chromium.org/2145823003 Cr-Commit-Position: refs/heads/master@{#405069} [add] https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed/third_party/WebKit/LayoutTests/fast/forms/text/text-dir-auto-with-placeholder.html [add] https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html [modify] https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed/third_party/WebKit/Source/core/html/HTMLElement.cpp
,
Jul 13 2016
I confirmed this was fixed with the current canary, 54.0.2795.0.
,
Jul 14 2016
[Automated comment] Less than 2 weeks to go before stable on M52, manual review required.
,
Jul 14 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 14 2016
[Automated comment] Less than 2 weeks to go before stable on M52, manual review required.
,
Jul 14 2016
Before we approve merge to M52, Could you please confirm whether this change is baked/verified in Canary and safe to merge?
,
Jul 14 2016
#12, Yes, I verified with canary, and I think it's safe.
,
Jul 14 2016
Approving merge to M52 branch 2743 based on comment #13. Please merge ASAP. Thank you.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/681eea95566832930b06d21f8b20200f3f04d361 commit 681eea95566832930b06d21f8b20200f3f04d361 Author: Kent Tamura <tkent@chromium.org> Date: Fri Jul 15 00:07:17 2016 Merge "Placeholder content direction should not affect INPUT/TEXTAREA direction." to M52 Skip -webkit-input-placeholder elements when we compute direction for dir=auto in HTMLElement::directionality. - Using <bdi> for placeholders doesn't work. We want to inherit placeholder direction from the parent element. - Using unicode-bidi CSS property doesn't work. It doesn't affect dir=auto computation. BUG= 625739 Review-Url: https://codereview.chromium.org/2145823003 Cr-Commit-Position: refs/heads/master@{#405069} (cherry picked from commit 55f27bb5c4f4f99a2885dc67bd6e448a464505ed) Review URL: https://codereview.chromium.org/2147353002 . Cr-Commit-Position: refs/branch-heads/2743@{#637} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [add] https://crrev.com/681eea95566832930b06d21f8b20200f3f04d361/third_party/WebKit/LayoutTests/fast/forms/text/text-dir-auto-with-placeholder.html [add] https://crrev.com/681eea95566832930b06d21f8b20200f3f04d361/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html [modify] https://crrev.com/681eea95566832930b06d21f8b20200f3f04d361/third_party/WebKit/Source/core/html/HTMLElement.cpp
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71e7fb4f9959f570961e6e57830658bafb2d0d4d commit 71e7fb4f9959f570961e6e57830658bafb2d0d4d Author: Kent Tamura <tkent@chromium.org> Date: Fri Jul 15 00:19:09 2016 Merge "Placeholder content direction should not affect INPUT/TEXTAREA direction." to M53. Skip -webkit-input-placeholder elements when we compute direction for dir=auto in HTMLElement::directionality. - Using <bdi> for placeholders doesn't work. We want to inherit placeholder direction from the parent element. - Using unicode-bidi CSS property doesn't work. It doesn't affect dir=auto computation. BUG= 625739 Review-Url: https://codereview.chromium.org/2145823003 Cr-Commit-Position: refs/heads/master@{#405069} (cherry picked from commit 55f27bb5c4f4f99a2885dc67bd6e448a464505ed) Review URL: https://codereview.chromium.org/2147373002 . Cr-Commit-Position: refs/branch-heads/2785@{#130} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [add] https://crrev.com/71e7fb4f9959f570961e6e57830658bafb2d0d4d/third_party/WebKit/LayoutTests/fast/forms/text/text-dir-auto-with-placeholder.html [add] https://crrev.com/71e7fb4f9959f570961e6e57830658bafb2d0d4d/third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html [modify] https://crrev.com/71e7fb4f9959f570961e6e57830658bafb2d0d4d/third_party/WebKit/Source/core/html/HTMLElement.cpp
,
Jul 19 2016
Verified the fix on Windows 7, MAC (10.11.5) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 52.0.2743.82 Screen-shots are attached. TE-Verified labels are added.
,
Jul 19 2016
,
Oct 12 2016
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by pinto....@gmail.com
, Jul 5 2016