New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625727 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 616673
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Get rid of Blink input event type converters

Project Member Reported by dcheng@chromium.org, Jul 5 2016

Issue description

We should get rid of these: they're hard to audit for correctness, since they have to silently swallow errors and return a semi-sensible value in case of invalid input. It looks like this one is ported from the html_viewer days.
 
dcheng@: Need a bit of context here: what did you mean by "this one"?

Comment 2 by dcheng@chromium.org, Jul 11 2016

"this one" is referring to all the Blink input event type converters. So in this instance, https://chromium.googlesource.com/chromium/src/+/master/mojo/converters/blink/blink_input_events_type_converters.h and its associated .cc need to go.

Comment 3 by ajha@chromium.org, Jul 18 2016

fsamuel@: Can we get an update on this Dev blocker issue.
Owner: sadrul@chromium.org
I'm not sure why I'm listed as owner here.
sadrul@, Any update on this dev blocker please.
Mergedinto: 616673
Status: Duplicate (was: Assigned)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment