https://bugs.chromium.org/p/chromium/issues/detail?id=625716&q=&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f6382c45e105322038b6fa1885cd1f479ef5ff8

commit 4f6382c45e105322038b6fa1885cd1f479ef5ff8
Author: dominickn <dominickn@chromium.org>
Date: Thu Jul 07 02:41:39 2016

Add metrics for app banner preventDefault() and prompt().

The beforeinstallprompt event signals an imminent app install banner for
a page. This CL adds UMA stats for preventDefault() being called on the
event (stopping the banner from appearing), and for prompt() being
called on the event (making the banner appear subsequent to
a preventDefault()).

BUG= 625716 

Review-Url: https://codereview.chromium.org/2122783002
Cr-Commit-Position: refs/heads/master@{#404039}

[modify] https://crrev.com/4f6382c45e105322038b6fa1885cd1f479ef5ff8/chrome/browser/banners/app_banner_data_fetcher.cc
[modify] https://crrev.com/4f6382c45e105322038b6fa1885cd1f479ef5ff8/chrome/browser/banners/app_banner_metrics.cc
[modify] https://crrev.com/4f6382c45e105322038b6fa1885cd1f479ef5ff8/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/4f6382c45e105322038b6fa1885cd1f479ef5ff8/tools/metrics/histograms/histograms.xml

Requesting permission to merge this metric to M52 and M53.

Your change meets the bar and is auto-approved for M52 (branch: 2743)

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd245a191fb03dff0d5d4594003befc30f749a9

commit 3dd245a191fb03dff0d5d4594003befc30f749a9
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Jul 07 08:35:58 2016

Add metrics for app banner preventDefault() and prompt().

The beforeinstallprompt event signals an imminent app install banner for
a page. This CL adds UMA stats for preventDefault() being called on the
event (stopping the banner from appearing), and for prompt() being
called on the event (making the banner appear subsequent to
a preventDefault()).

BUG= 625716 

Review-Url: https://codereview.chromium.org/2122783002
Cr-Commit-Position: refs/heads/master@{#404039}
(cherry picked from commit 4f6382c45e105322038b6fa1885cd1f479ef5ff8)

Review URL: https://codereview.chromium.org/2132483002 .

Cr-Commit-Position: refs/branch-heads/2743@{#592}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/3dd245a191fb03dff0d5d4594003befc30f749a9/chrome/browser/banners/app_banner_data_fetcher.cc
[modify] https://crrev.com/3dd245a191fb03dff0d5d4594003befc30f749a9/chrome/browser/banners/app_banner_metrics.cc
[modify] https://crrev.com/3dd245a191fb03dff0d5d4594003befc30f749a9/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/3dd245a191fb03dff0d5d4594003befc30f749a9/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b533085ebf0bb4148b47ec27faf62e1619a4c5f1

commit b533085ebf0bb4148b47ec27faf62e1619a4c5f1
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Jul 08 00:44:18 2016

Add metrics for app banner preventDefault() and prompt().

The beforeinstallprompt event signals an imminent app install banner for
a page. This CL adds UMA stats for preventDefault() being called on the
event (stopping the banner from appearing), and for prompt() being
called on the event (making the banner appear subsequent to
a preventDefault()).

BUG= 625716 

Review-Url: https://codereview.chromium.org/2122783002
Cr-Commit-Position: refs/heads/master@{#404039}
(cherry picked from commit 4f6382c45e105322038b6fa1885cd1f479ef5ff8)

Review URL: https://codereview.chromium.org/2130173002 .

Cr-Commit-Position: refs/branch-heads/2785@{#50}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/b533085ebf0bb4148b47ec27faf62e1619a4c5f1/chrome/browser/banners/app_banner_data_fetcher.cc
[modify] https://crrev.com/b533085ebf0bb4148b47ec27faf62e1619a4c5f1/chrome/browser/banners/app_banner_metrics.cc
[modify] https://crrev.com/b533085ebf0bb4148b47ec27faf62e1619a4c5f1/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/b533085ebf0bb4148b47ec27faf62e1619a4c5f1/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48

commit cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48
Author: dominickn <dominickn@chromium.org>
Date: Fri Jul 08 17:38:31 2016

Add UseCounters for BeforeInstallPromptEvent.

These stats will help identify how often developers catch the event and
call its methods.

BUG= 625716 

Review-Url: https://codereview.chromium.org/2121083002
Cr-Commit-Position: refs/heads/master@{#404430}

[modify] https://crrev.com/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp
[modify] https://crrev.com/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h
[modify] https://crrev.com/cad44b02ae8dd0acfbcbcd08fb5cce2a5e845f48/tools/metrics/histograms/histograms.xml