New issue
Advanced search Search tips

Issue 625711 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Please make default icon size 128x128

Reported by nuk...@gmail.com, Jul 4 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce the problem:
1. open Chromium
2. Press Alt-Tab to show Task Switcher
3. 

What is the expected behavior?
Show 128x128 sized logo.

What went wrong?
Icon of chromium is blurred and upscaled.
This is a duplicated bug of  Issue 459354 . However, that bug is already closed because of inactivity.

I meet the same issue in version 51.0, plasma 5.6.95.
I hope chormium can use 128x128 sized icons as default. It is an easy fix, just apply the following patch.

--- chrome/browser/ui/views/chrome_views_delegate.cc.bak        2015-01-21 11:55:41.495893370 -0700
+++ chrome/browser/ui/views/chrome_views_delegate.cc    2015-01-21 11:55:55.734854507 -0700
@@ -237,7 +237,7 @@
 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)
 gfx::ImageSkia* ChromeViewsDelegate::GetDefaultWindowIcon() const {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
-  return rb.GetImageSkiaNamed(IDR_PRODUCT_LOGO_64);
+  return rb.GetImageSkiaNamed(IDR_PRODUCT_LOGO_128);
 }
 #endif

Did this work before? No 

Chrome version: 51.0.2704.103  Channel: stable
OS Version: openSUSE Tumbleweed
Flash Version: Shockwave Flash 22.0 r0
 

Comment 1 by sl1pk...@gmail.com, Jan 19 2017

is not better implement SVG (scalable vectors) instead of fixed-size image?
 Issue 459354  has been merged into this issue.
Cc: thomasanderson@chromium.org
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c

commit e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Nov 22 23:06:39 2017

Distinguish Chrome window icons for different channels on Linux

Also, use 128x128 icons to fix  bug 625711 .

BUG= 625711 , 773489 
R=thestig@chromium.org

Change-Id: Ifbe99e82bf29a0838b9322db3c6a3d27bc2b5ed9
Reviewed-on: https://chromium-review.googlesource.com/786531
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518786}
[modify] https://crrev.com/e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c/chrome/app/theme/chrome_unscaled_resources.grd
[modify] https://crrev.com/e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c/chrome/browser/ui/views/chrome_views_delegate_linux.cc

Status: Fixed (was: Assigned)

Sign in to add a comment