`git-cl try` should just trigger a CQ dry run, rather than working off of local state |
||||||
Issue descriptionVersion: r400415 OS: Win10 (but probably irrelevant) What steps will reproduce the problem? (1) Run "git cl try" What is the expected output? All bots on CL are yellow What do you see instead? mac_chromium_gn_rel is purple and isn't listed in "Choose trybots" so I assume it doesn't exist.
,
Jul 5 2016
It's pulled from cq.cfg *locally*. That basically means the uploaded branch needs a rebase. However, I agree that the current state of the tool isn't good. I think we should redirect "git cl try" with no arguments to actually trigger CQ dry run.
,
Jul 5 2016
,
Jul 5 2016
Hmmm how "long" ago was that bot removed? My local branch isn't uber far behind.
,
Jul 5 2016
Well okay, checking on my desktop this morning and my branch is on r400415 (June 17), is that considered "a while ago"? If so feel free to WontFix this (or keep it open to change default git cl try to be a CQ dry run -- that would make sense to me).
,
Jul 5 2016
Yes, that fits within my "a while ago" :). I actually thought we had already changed `git cl try` to trigger a dry run. I'll update the subject to reflect the new request.
,
Jul 6 2016
,
Jul 7 2016
I've send a proposal to chromium-dev: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/Ale4kvbwVS8/mvcPUjSLAAAJ
,
Jul 12 2016
CL uploaded: https://codereview.chromium.org/2147563003
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9de9ec66b3a0b8f17dc8c15069add8f62b9796a6 commit 9de9ec66b3a0b8f17dc8c15069add8f62b9796a6 Author: tandrii <tandrii@chromium.org> Date: Wed Jul 13 10:01:59 2016 git cl try: Trigger CQ Dry Run by default. If bots are specified manually on command line OR in PRESUBMIT.py, then old behavior remains, namely triggering just those bots. Otherwise, git cl try will now trigger CQ Dry Run. This is a good default and also resolves several bugs: * https://crbug.com/581150 where git cl try used to load cq.cfg from infra/config, but that's not always correct for all projects. * https://crbug.com/625697 where even if cq.cfg is in default location. it might be outdated. * https://crbug.com/585237 where git cl try would ignore special in CL description CQ_INCLUDE_TRYBOTS, which is processed by CQ, but not git cl try. BUG= 625697 , 585237 ,581150 R=sergiyb@chromium.org,emso@chromium.org Review-Url: https://codereview.chromium.org/2147563003 [modify] https://crrev.com/9de9ec66b3a0b8f17dc8c15069add8f62b9796a6/git_cl.py [modify] https://crrev.com/9de9ec66b3a0b8f17dc8c15069add8f62b9796a6/tests/git_cl_test.py
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/42bf4be9fb5a485421297fbaf89d222f8e9312d8 commit 42bf4be9fb5a485421297fbaf89d222f8e9312d8 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 10:16:31 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/9de9ec66b3a0b8f17dc8c15069add8f62b9796a6 git cl try: Trigger CQ Dry Run by default. (tandrii@chromium.org) R=emso@chromium.org,sergiyb@chromium.org,tandrii@chromium.org BUG=581150, 585237 , 625697 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2144873003 [modify] https://crrev.com/42bf4be9fb5a485421297fbaf89d222f8e9312d8/infra/config/recipes.cfg
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/2136c8a82103a6027ea6e99d29a61849edd76ee9 commit 2136c8a82103a6027ea6e99d29a61849edd76ee9 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 11:23:32 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/42bf4be9fb5a485421297fbaf89d222f8e9312d8 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/bbc4963447bca0ff3b7b13637751e660f2bd6188 V8: Skip 'failure reason' step in gatekeeper (machenbach@chromium.org) depot_tools: https://crrev.com/9de9ec66b3a0b8f17dc8c15069add8f62b9796a6 git cl try: Trigger CQ Dry Run by default. (tandrii@chromium.org) R=iannucci@chromium.org,tandrii@chromium.org,machenbach@chromium.org,emso@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org,sergiyb@chromium.org BUG=581150, 585237 , 625697 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2143403002 [modify] https://crrev.com/2136c8a82103a6027ea6e99d29a61849edd76ee9/infra/config/recipes.cfg |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpranke@chromium.org
, Jul 4 2016