New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625686 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: 56-Dev , 56-Beta , 56-Stable
Launch-M-Target: 56-Dev , 56-Beta , 56-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----
M56



Sign in to add a comment

Implement KeyboardEvent.isComposing

Project Member Reported by dtapu...@chromium.org, Jul 4 2016

Issue description

Knowledge whether we are inside an IME processing context is useful.

Specifically we should support the specified isComposing flag of KeyboardEvent

https://w3c.github.io/uievents/#dom-inputevent-iscomposing
 
Should it be https://w3c.github.io/uievents/#dom-keyboardevent-iscomposing?

InputEvent already has |isComposing| support.
Yes sorry for the wrong URI in #0. Thanks chongz@
Labels: -Type-Bug Type-Launch-OWP
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c3223b3a1e3c570aab417f3c89eb0410341c5b8

commit 3c3223b3a1e3c570aab417f3c89eb0410341c5b8
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Nov 01 22:12:27 2016

Add isComposing support for KeyboardEvents

Initialize isComposing based on the value that the
InputMethodController has when we are constructing
natively backed events.

Approved Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6o1W8mVUDsA/JOKZ-aRfBwAJ

BUG= 625686 

Review-Url: https://codereview.chromium.org/2454073005
Cr-Commit-Position: refs/heads/master@{#429133}

[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/LayoutTests/imported/wpt/dom/events/Event-subclasses-constructors-expected.txt
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/Source/core/events/KeyboardEvent.h
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/Source/core/events/KeyboardEvent.idl
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/Source/core/events/KeyboardEventInit.idl
[modify] https://crrev.com/3c3223b3a1e3c570aab417f3c89eb0410341c5b8/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Labels: M56 Launch-M-Approved-56-Dev Launch-M-Approved-56-Beta Launch-M-Approved-56-Stable Launch-M-Target-56-Dev Launch-M-Target-56-Beta Launch-M-Target-56-Stable
Status: Fixed (was: Assigned)

Sign in to add a comment