Issue 625684 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	dtapu...@chromium.org
Closed:	Feb 2017
Cc:	tdres...@chromium.org majidvp@chromium.org
Components:	Blink>Input
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-CodeHealth Hotlist-Input-Dev

Combine PlatformEvent and WebInputEvent

Project Member Reported by dtapu...@chromium.org, Jul 4 2016

Issue description

Move WebInputEvent into public/platform and remove the PlatformEvent abstraction.

This would end up cleaning up a whole lot of duplication.

We need to be careful about how this is done for the translated event coordinates that occur. But it shouldn't be too difficult.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8502cd585148bb893a32ee61fc3998557a318737

commit 8502cd585148bb893a32ee61fc3998557a318737
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jul 22 17:16:29 2016

Move WebInputEvent into public/platform from public/web

Some preliminary work to remove PlatformEvent abstractions.

Rename a constant to pass check-webkit-style.

BUG= 625684 
TBR=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2173073003
Cr-Commit-Position: refs/heads/master@{#407186}

[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/components/test_runner/event_sender.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/components/test_runner/event_sender.h
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/components/test_runner/test_plugin.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/browser/renderer_host/input/synthetic_pointer_action.h
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/browser/renderer_host/input/touch_event_queue_unittest.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/common/input/event_with_latency_info.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/public/blink_headers.gyp
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/public/blink_headers.gypi
[add] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/public/platform/WebInputEvent.h
[rename] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/public/platform/WebTouchPoint.h
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/third_party/WebKit/public/web/WebInputEvent.h
[modify] https://crrev.com/8502cd585148bb893a32ee61fc3998557a318737/ui/events/blink/blink_event_util.cc

Comment 2 by dtapu...@chromium.org, Aug 26 2016

Labels: Hotlist-CodeHealth

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d

commit 98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d
Author: dtapuska <dtapuska@chromium.org>
Date: Wed Aug 31 01:53:24 2016

Remove PlatformKeyboardEvent

Remove abstraction for PlatformKeyboardEvent and use WebKeyboardEvent
directly inside core.

BUG= 625684 

Review-Url: https://codereview.chromium.org/2290313002
Cr-Commit-Position: refs/heads/master@{#415535}

[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/events/KeyboardEvent.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/input/KeyboardEventManager.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/inspector/InspectorInputAgent.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/platform/PlatformEvent.h
[delete] https://crrev.com/7afbba8585b360b94ef4e9cc4497a93b12987587/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
[delete] https://crrev.com/7afbba8585b360b94ef4e9cc4497a93b12987587/third_party/WebKit/Source/platform/PlatformKeyboardEvent.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebAXObject.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebPagePopupImpl.h
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/tests/KeyboardTest.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d/third_party/WebKit/public/platform/WebInputEvent.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/836e1f9ab3c35283a065df5557e5836402043c35

commit 836e1f9ab3c35283a065df5557e5836402043c35
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Nov 15 00:38:06 2016

Break apart WebGestureEvent from WebInputEvent.

New methods need to be added to WebGestureEvent and it makes no
sense to keep expanding the really large WebInputEvent.

Since I'm adjusting a number of the include locations get rid of
web/WebInputEvent.h as well; largely done via sed.

No behavioural changes intended.

BUG= 625684 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=rockot@chromium.org, sadrul@chromium.org, wez@chromium.org, dcheng@chromium.org, girard@chromium.org, jochen@chromium.org, creis@chromium.org

Review-Url: https://codereview.chromium.org/2497033002
Cr-Commit-Position: refs/heads/master@{#432021}

[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/client/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/client/core/input/blimp_input_manager.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/client/core/render_widget/mock_render_widget_feature.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/client/core/render_widget/mock_render_widget_feature.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/engine/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/engine/browser_tests/input_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/engine/feature/engine_render_widget_feature.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/net/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/net/input_message_converter.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/net/input_message_generator.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/blimp/net/input_message_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/android/vr_shell/vr_input_manager.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/chromeos/first_run/first_run_view.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/extensions/extension_view_host.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/plugins/flash_permission_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/chrome/test/base/chrome_render_view_test.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/autofill/content/renderer/page_click_tracker.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/guest_view/browser/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/plugins/renderer/loadable_plugin_placeholder.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/test_runner/event_sender.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/test_runner/test_plugin.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/components/test_runner/text_input_controller.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/android/content_view_core_impl.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/frame_host/render_widget_host_view_guest.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/gesture_event_queue.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/input_ack_handler.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/input_router.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/input_router_client.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/main_thread_event_queue_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/motion_event_web.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/mouse_wheel_event_queue.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/non_blocking_event_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_gesture_target_android.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_pointer.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_pointer_action.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_smooth_move_gesture.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_tap_gesture.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_action_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_action_filter_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_emulator_client.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_event_queue.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_event_queue_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touch_input_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/touchpad_tap_suppression_controller.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/web_input_event_builders_android.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/web_input_event_builders_android_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/web_input_event_builders_mac.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/overscroll_controller.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/renderer_host/ui_events_helper.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/browser/web_contents/web_drag_dest_mac.mm
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/android/sync_compositor_messages.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/content_param_traits.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/content_param_traits_macros.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/event_with_latency_info_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/gesture_event_stream_validator.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/input_event_ack.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/input_event_stream_validator.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/synthetic_web_input_event_builders.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/touch_event_stream_validator.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input/web_touch_event_traits.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/common/input_messages.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/public/browser/native_web_keyboard_event.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/public/browser/render_widget_host.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/public/browser/render_widget_host_view.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/public/test/browser_test_utils.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/public/test/render_view_test.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/input/input_event_filter.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/input/input_handler_manager_client.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/input/main_thread_event_queue.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/input/render_widget_input_handler.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/mouse_lock_dispatcher.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/mus/compositor_mus_connection.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/pepper/event_conversion.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/pepper/plugin_instance_throttler_impl.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/render_view_impl.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/render_view_impl.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/extensions/browser/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/extensions/browser/app_window/app_web_contents_helper.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/InspectorOverlay.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/PageWidgetDelegate.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/public/platform/WebGestureEvent.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/public/platform/WebInputEvent.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/third_party/WebKit/public/web/WebActiveWheelFlingParameters.h
[delete] https://crrev.com/a1b3b4d39c4de0bf2aee5ee20ac7d321a3d37eed/third_party/WebKit/public/web/WebInputEvent.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/content_accelerators/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/content_accelerators/accelerator_util.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/blink_event_util_unittest.cc
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/input_scroll_elasticity_controller.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/web_input_event.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/events/blink/web_input_event_traits.h
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/web_dialogs/DEPS
[modify] https://crrev.com/836e1f9ab3c35283a065df5557e5836402043c35/ui/web_dialogs/web_dialog_web_contents_delegate.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b35a48fdbcd6de3457f979fd8b873eb27935371

commit 3b35a48fdbcd6de3457f979fd8b873eb27935371
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Dec 02 00:22:12 2016

Remove dead code processing wheel gesture phase.

This code dates back to WebKit with the scroll tree
handling mouse wheel events. The calling code was
eventually removed yet these functions remained.

BUG= 625684 

Review-Url: https://codereview.chromium.org/2547653002
Cr-Commit-Position: refs/heads/master@{#435789}

[modify] https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
[modify] https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h
[modify] https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/3b35a48fdbcd6de3457f979fd8b873eb27935371/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a17610ebf43599366634ea11c9cac7ff933973b

commit 7a17610ebf43599366634ea11c9cac7ff933973b
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Dec 16 18:25:05 2016

Remove PlatformGestureEvent in favour of using WebGestureEvent

This change is intended to have no behavioural changes. Some of the math
is slightly adjusted the root frame coordinates. The root frame
coordinates are calculated via:
A/scale - B/scale + VO + OO
as it was previously
(A-B)/scale + VO + OO

If this is a problem we can store translateX and translateY as the actual
coordinates instead instead a computation.

Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2539283002
Cr-Commit-Position: refs/heads/master@{#439153}

[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/editing/SelectionController.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/events/GestureEvent.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/events/GestureEvent.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/GestureManager.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/input/ScrollManager.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/page/EventWithHitTestResults.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/PlatformEvent.h
[delete] https://crrev.com/4e4ba3ddca6eddfaf1cbef77cc30c225277ba53d/third_party/WebKit/Source/platform/PlatformGestureEvent.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/PlatformMouseEvent.h
[add] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/WebGestureEvent.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/scroll/ScrollTypes.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/platform/scroll/Scrollbar.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/InspectorOverlay.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/public/platform/WebGestureEvent.h
[modify] https://crrev.com/7a17610ebf43599366634ea11c9cac7ff933973b/third_party/WebKit/public/platform/WebInputEvent.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6889dbe1c0db9e519f9992f72ebfcd1e94af028

commit e6889dbe1c0db9e519f9992f72ebfcd1e94af028
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Dec 19 03:49:07 2016

Remove MouseRelatedEvent

Nobody uses mice anymore. No seriously there is only one subclass
of MouseRelatedEvent... MouseEvent. Collapse them together.

BUG= 625684 

Review-Url: https://codereview.chromium.org/2580083002
Cr-Commit-Position: refs/heads/master@{#439400}

[modify] https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028/third_party/WebKit/Source/core/events/BUILD.gn
[modify] https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028/third_party/WebKit/Source/core/events/MouseEvent.h
[delete] https://crrev.com/14169abdc6f1d31468cb1de6212ff256c89b92b2/third_party/WebKit/Source/core/events/MouseRelatedEvent.cpp
[delete] https://crrev.com/14169abdc6f1d31468cb1de6212ff256c89b92b2/third_party/WebKit/Source/core/events/MouseRelatedEvent.h
[modify] https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028/third_party/WebKit/Source/core/events/TouchEvent.h
[modify] https://crrev.com/e6889dbe1c0db9e519f9992f72ebfcd1e94af028/third_party/WebKit/Source/web/WebInputEventConversion.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234bb451a006c60823f0ade952cde5232683cd2d

commit 234bb451a006c60823f0ade952cde5232683cd2d
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Dec 19 21:46:18 2016

Move WebMouseWheelEvent into its own header file.

No changes other than modifying includes and appropriately forward
declaring the class.

BUG= 625684 
TBR=dcheng@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2581943003
Cr-Commit-Position: refs/heads/master@{#439579}

[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/chrome/browser/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/components/test_runner/event_sender.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/web_input_event_builders_android.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/web_input_event_builders_mac.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/gesture_event_stream_validator.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/input_event_stream_validator.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/synthetic_web_input_event_builders.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/public/browser/render_widget_host.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/public/platform/WebInputEvent.h
[add] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/public/platform/WebMouseWheelEvent.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_scroll_elasticity_controller_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_builders_win.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_traits.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_traits_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234bb451a006c60823f0ade952cde5232683cd2d

commit 234bb451a006c60823f0ade952cde5232683cd2d
Author: dtapuska <dtapuska@chromium.org>
Date: Mon Dec 19 21:46:18 2016

Move WebMouseWheelEvent into its own header file.

No changes other than modifying includes and appropriately forward
declaring the class.

BUG= 625684 
TBR=dcheng@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2581943003
Cr-Commit-Position: refs/heads/master@{#439579}

[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/chrome/browser/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/components/test_runner/event_sender.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/web_input_event_builders_android.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/input/web_input_event_builders_mac.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/gesture_event_stream_validator.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/input_event_stream_validator.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/common/input/synthetic_web_input_event_builders.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/public/browser/render_widget_host.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/public/platform/WebInputEvent.h
[add] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/third_party/WebKit/public/platform/WebMouseWheelEvent.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/DEPS
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/input_scroll_elasticity_controller_unittest.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_builders_win.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_traits.h
[modify] https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d/ui/events/blink/web_input_event_traits_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/899ac22255a8d7856d70e41425469e977e0d9f61

commit 899ac22255a8d7856d70e41425469e977e0d9f61
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Jan 03 18:09:16 2017

Add constructors to WebInputEvents and setters so we can work at
cleaning up these public structs.

Adding constructors allow us to ensure that certain fields such as the
timestamp are initialized correctly without having to default initialize
it with a slow API call like querying the current time.

Design: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
TBR=wez@chromium.org, thestig@chromium.org, dcheng@chromium.org, clamy@chromium.org

Review-Url: https://codereview.chromium.org/2569273002
Cr-Commit-Position: refs/heads/master@{#441153}

[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/blimp/client/core/input/blimp_input_manager.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/blimp/engine/browser_tests/input_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/blimp/engine/feature/engine_render_widget_feature_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/blimp/net/input_message_converter.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/blimp/net/input_message_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/page_load_metrics/user_input_tracker_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/password_manager/password_generation_interactive_uitest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/ui/cocoa/browser_window_utils_unittest.mm
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/components/test_runner/event_sender.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/components/test_runner/event_sender.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/components/test_runner/text_input_controller.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/input_router_impl_perftest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/mock_input_ack_handler.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/mock_input_ack_handler.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/synthetic_mouse_driver.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/synthetic_touch_driver.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/touch_event_queue.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/touch_event_queue_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/input/web_input_event_util_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/native_web_keyboard_event_android.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/native_web_keyboard_event_aura.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/native_web_keyboard_event_mac.mm
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/event_with_latency_info.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/event_with_latency_info_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/synthetic_web_input_event_builders.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/common/input/web_touch_event_traits.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/public/browser/native_web_keyboard_event.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/public/test/render_view_test.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/input/input_event_filter_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/KeyboardTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/public/platform/WebGestureEvent.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/public/platform/WebInputEvent.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/third_party/WebKit/public/platform/WebMouseWheelEvent.h
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/event_with_callback.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/input_scroll_elasticity_controller_unittest.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/899ac22255a8d7856d70e41425469e977e0d9f61/ui/events/blink/web_input_event_traits_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac51325cc9bb568a337f38e300cdaa5c1c47099a

commit ac51325cc9bb568a337f38e300cdaa5c1c47099a
Author: dtapuska <dtapuska@chromium.org>
Date: Thu Jan 05 19:39:44 2017

Remove PlatformWheelEvent and use WebMouseWheelEvent instead

Perform similar cleanup as GestureEvents used in change:
https://codereview.chromium.org/2539283002/

Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 

Review-Url: https://codereview.chromium.org/2586133003
Cr-Commit-Position: refs/heads/master@{#441735}

[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/events/UIEventWithKeyState.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/events/WheelEvent.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/events/WheelEvent.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/platform/PlatformEvent.h
[delete] https://crrev.com/2805edaba1b852b6ce489a8f88bd8e90e51b73d2/third_party/WebKit/Source/platform/PlatformWheelEvent.h
[add] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/platform/WebMouseEvent.cpp
[add] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/platform/WebMouseWheelEvent.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/public/platform/WebInputEvent.h
[modify] https://crrev.com/ac51325cc9bb568a337f38e300cdaa5c1c47099a/third_party/WebKit/public/platform/WebMouseWheelEvent.h

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a794bd081b2465e336f2ad92f9e8c45c140ea144

commit a794bd081b2465e336f2ad92f9e8c45c140ea144
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jan 06 15:22:55 2017

Move WebMouseEvent into its own header file.

No changes other than modifying includes and appropriately forward
declaring the class.

BUG= 625684 
TBR=girard@chromium.org, clamy@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2590273002
Cr-Commit-Position: refs/heads/master@{#441940}

[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/chrome/browser/DEPS
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/chrome/browser/android/vr_shell/vr_input_manager.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/chrome/renderer/plugins/chrome_plugin_placeholder.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/components/autofill/content/renderer/page_click_tracker.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/components/test_runner/test_plugin.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/browser/DEPS
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/public/test/browser_test_utils.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/public/test/render_view_test.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/public/test/render_view_test.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/renderer/mouse_lock_dispatcher_browsertest.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/content/renderer/render_widget.cc
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/Source/platform/WebMouseEvent.cpp
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/Source/web/tests/FrameTestHelpers.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/public/platform/WebInputEvent.h
[add] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/public/platform/WebMouseEvent.h
[modify] https://crrev.com/a794bd081b2465e336f2ad92f9e8c45c140ea144/third_party/WebKit/public/platform/WebMouseWheelEvent.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5

commit 8c4dae156ba6495186bebe76aa4be4dc76bd7cd5
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jan 13 00:23:06 2017

Collapse the API surface on WebInputEvent via accessor functions.

Move type, size, timeStampSeconds and modifiers to be private members.
This change will help harden the API so that we can place DCHECKS on
certain states.

Design: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 
TBR=jochen@chromium.org, wez@chromium.org, thestig@chromium.org, sadrul@chromium.org, rockot@chromium.org, dcheng@chromium.org, girard@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2573073003
Cr-Commit-Position: refs/heads/master@{#443407}

[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/blimp/client/core/input/blimp_input_handler_wrapper.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/blimp/client/core/input/blimp_input_manager.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/blimp/engine/session/tab.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/blimp/net/input_message_generator.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/blimp/net/input_message_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/android/vr_shell/vr_input_manager.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/chromeos/first_run/first_run_view.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/extensions/extension_view_host.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/page_load_metrics/user_input_tracker.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/page_load_metrics/user_input_tracker_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/app_list/start_page_service.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/browser.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/cocoa/browser_window_utils.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/exclusive_access/exclusive_access_manager.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/components/test_runner/event_sender.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/components/test_runner/test_plugin.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/browser_plugin/browser_plugin_embedder.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/input_router_impl_perftest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/mock_input_ack_handler.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/motion_event_web.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/synthetic_gesture_target_android.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touch_action_filter_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touch_event_queue.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touch_event_queue_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/input/web_input_event_util_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/native_web_keyboard_event_aura.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/renderer_host/ui_events_helper.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/content_param_traits.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/event_with_latency_info.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/event_with_latency_info_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/gesture_event_stream_validator.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/input_event_stream_validator.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/touch_event_stream_validator.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/touch_event_stream_validator_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/common/input/web_touch_event_traits.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/input/input_event_filter_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/mus/compositor_mus_connection_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/pepper/event_conversion_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/pepper/plugin_instance_throttler_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/render_widget.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/extensions/browser/app_window/app_web_contents_helper.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/events/GestureEvent.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/platform/WebGestureEvent.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/DevToolsEmulator.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/public/platform/WebGestureEvent.h
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/third_party/WebKit/public/platform/WebInputEvent.h
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/content_accelerators/accelerator_util.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/blink_event_util.h
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/compositor_thread_event_queue.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/event_with_callback.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/input_scroll_elasticity_controller.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/web_input_event_builders_win.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/events/blink/web_input_event_unittest.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/views/controls/webview/unhandled_keyboard_event_handler.cc
[modify] https://crrev.com/8c4dae156ba6495186bebe76aa4be4dc76bd7cd5/ui/web_dialogs/web_dialog_web_contents_delegate.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a64845daa6b3951b2f6891c6bbf37cfff568dde9

commit a64845daa6b3951b2f6891c6bbf37cfff568dde9
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jan 20 21:20:45 2017

Give WebTouchEvent and WebKeyboardEvent their own headers

No functional changes intended. Just moving code around to make
clear structs be defined in their own header.

BUG= 625684 
TBR=jochen@chromium.org, dcheng@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2639273002
Cr-Commit-Position: refs/heads/master@{#445166}

[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/components/test_runner/event_sender.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/components/test_runner/test_plugin.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/components/test_runner/text_input_controller.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/DEPS
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/motion_event_web.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/touch_emulator_client.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/web_input_event_builders_android.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/browser/renderer_host/input/web_input_event_builders_mac.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/DEPS
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/event_with_latency_info.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/synthetic_pointer_action_params.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/synthetic_web_input_event_builders.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/touch_event_stream_validator.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/touch_event_stream_validator.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/web_touch_event_traits.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/common/input/web_touch_event_traits.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/public/browser/native_web_keyboard_event.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/content/renderer/render_widget.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/core/events/KeyboardEvent.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/core/input/KeyboardEventManager.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/public/platform/WebInputEvent.h
[add] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/public/platform/WebKeyboardEvent.h
[add] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/third_party/WebKit/public/platform/WebTouchEvent.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/DEPS
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/blink_event_util.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/web_input_event.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/web_input_event_builders_win.h
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/a64845daa6b3951b2f6891c6bbf37cfff568dde9/ui/events/blink/web_input_event_traits_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f7cc1167a9026405c671be0f81ff551f9ebd47b

commit 5f7cc1167a9026405c671be0f81ff551f9ebd47b
Author: dtapuska <dtapuska@chromium.org>
Date: Fri Jan 27 21:37:13 2017

Remove PlatformTouchEvent/Point and use WebTouchEvent/Point instead

Perform similar cleanup as GestureEvents used in change:
https://codereview.chromium.org/2539283002/
https://codereview.chromium.org/2586133003

Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 

Review-Url: https://codereview.chromium.org/2646163002
Cr-Commit-Position: refs/heads/master@{#446782}

[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/PointerEvent.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/TouchEvent.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/events/UIEventWithKeyState.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/input/PointerEventManager.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/input/TouchEventManager.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/platform/PlatformEvent.h
[delete] https://crrev.com/168f89bd6a4f37942fe8d05f59b903fe822dfcc2/third_party/WebKit/Source/platform/PlatformTouchEvent.h
[delete] https://crrev.com/168f89bd6a4f37942fe8d05f59b903fe822dfcc2/third_party/WebKit/Source/platform/PlatformTouchPoint.h
[add] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/platform/WebTouchEvent.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/InspectorOverlay.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/public/platform/WebTouchEvent.h
[modify] https://crrev.com/5f7cc1167a9026405c671be0f81ff551f9ebd47b/third_party/WebKit/public/platform/WebTouchPoint.h

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a0ddfbef3bfb61f2de91026ac1e749172917210

commit 6a0ddfbef3bfb61f2de91026ac1e749172917210
Author: dtapuska <dtapuska@chromium.org>
Date: Sat Jan 28 00:39:32 2017

Remove PlatformMouseEvent and use WebMouseEvent instead

Perform similar cleanup as GestureEvents used in change:
https://codereview.chromium.org/2539283002/
https://codereview.chromium.org/2586133003/
https://codereview.chromium.org/2646163002/

Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2650403006
Cr-Commit-Position: refs/heads/master@{#446853}

[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/dom/Node.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/editing/SelectionController.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/DragEvent.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/DragEvent.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/PointerEventFactory.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/events/WheelEvent.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/EventHandlingUtil.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/EventHandlingUtil.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/MouseEventManager.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/PointerEventManager.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/input/ScrollManager.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/layout/HitTestResult.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/layout/LayoutScrollbarTheme.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/AutoscrollController.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/AutoscrollController.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/DragController.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/EventWithHitTestResults.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/PointerLockController.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/page/PointerLockController.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/core/svg/SVGAElement.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/PlatformEvent.h
[delete] https://crrev.com/14bb3dc50a132c22dae437c7ee7cccc18948f718/third_party/WebKit/Source/platform/PlatformMouseEvent.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/WebMouseEvent.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/Scrollbar.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/InspectorOverlay.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/PageWidgetDelegate.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/PopupMenuImpl.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebInputEventConversion.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebInputEventConversion.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/public/platform/WebInputEvent.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/public/platform/WebMouseEvent.h
[modify] https://crrev.com/6a0ddfbef3bfb61f2de91026ac1e749172917210/third_party/WebKit/public/platform/WebPointerProperties.h

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e19843aade96a4a3b2254ba00896ddd15e5a153

commit 4e19843aade96a4a3b2254ba00896ddd15e5a153
Author: dtapuska <dtapuska@chromium.org>
Date: Tue Feb 14 19:27:47 2017

Remove PlatformEvent it is no longer used.

All events have been converted to use WebInputEvent directly.

Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG= 625684 

Review-Url: https://codereview.chromium.org/2655873003
Cr-Commit-Position: refs/heads/master@{#450433}

[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/DragEvent.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/DragEvent.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/GestureEvent.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/KeyboardEvent.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/TouchEvent.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/events/UIEventWithKeyState.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/EventHandler.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/GestureManager.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/KeyboardEventManager.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/input/ScrollManager.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/core/page/EventWithHitTestResults.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/dc5d94e5233d935b5a20380c5f0271112b594786/third_party/WebKit/Source/platform/PlatformEvent.h
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
[modify] https://crrev.com/4e19843aade96a4a3b2254ba00896ddd15e5a153/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp

Comment 18 by dtapu...@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)

►

Issue 625684 link

Issue metadata

Combine PlatformEvent and WebInputEvent

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

Comment 1 Deleted

Comment 2 by dtapu...@chromium.org, Aug 26 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Aug 31 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Nov 15 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Dec 2 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Dec 16 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Dec 19 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Dec 19 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jan 3 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Jan 5 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jan 6 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Jan 13 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Jan 20 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Jan 27 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Jan 28 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Feb 14 2017

Comment 17 Deleted

Comment 18 by dtapu...@chromium.org, Feb 23 2017

Comment 18 Deleted

Sign in to add a comment