New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625676 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 589726



Sign in to add a comment

Failing DCHECK in scroll customization logic

Project Member Reported by tdres...@chromium.org, Jul 4 2016

Issue description

ASSERTION FAILED: isAllowedToQueryCompositingState()
../../third_party/WebKit/Source/core/paint/PaintLayer.cpp(2284) : blink::CompositingState blink::PaintLayer::compositin
gState() const
1   0x7fd2ddc7a383 blink::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(blink::FrameView*) cons
t
2   0x7fd2ddc7710e blink::ScrollingCoordinator::mainThreadScrollingReasons() const
3   0x7fd2ddb120df blink::FrameView::shouldScrollOnMainThread() const
4   0x7fd2e584eb85 blink::ScrollAnimator::willAnimateToOffset(blink::FloatPoint const&)
5   0x7fd2e584e968 blink::ScrollAnimator::userScroll(blink::ScrollGranularity, blink::FloatSize const&)
6   0x7fd2ddb51571 blink::RootFrameViewport::userScroll(blink::ScrollGranularity, blink::FloatSize const&)
7   0x7fd2ddc83dbb
8   0x7fd2dd5c143c blink::Element::callApplyScroll(blink::ScrollState&)
9   0x7fd2dd5c13a3 blink::Element::nativeDistributeScroll(blink::ScrollState&)
10  0x7fd2dd6c5604 blink::ScrollManager::customizedScroll(blink::Node const&, blink::ScrollState&)
11  0x7fd2dd6c5d97 blink::ScrollManager::handleGestureScrollUpdate(blink::PlatformGestureEvent const&)
12  0x7fd2dd6c6357 blink::ScrollManager::handleGestureScrollEvent(blink::PlatformGestureEvent const&)
13  0x7fd2dd6b7ed2 blink::EventHandler::handleGestureScrollEvent(blink::PlatformGestureEvent const&)
14  0x7fd2e554716d blink::WebViewImpl::handleGestureEvent(blink::WebGestureEvent const&)
15  0x7fd2e54c9c10
16  0x7fd2e5548b94 blink::WebViewImpl::handleInputEvent(blink::WebInputEvent const&)
17  0x7fd2e8ea809c content::RenderWidgetInputHandler::HandleInputEvent(blink::WebInputEvent const&, ui::LatencyInfo con
st&, content::InputEventDispatchType)
18  0x7fd2e8f3dc3f
19  0x7fd2e8f3d3e7 content::RenderWidget::OnMessageReceived(IPC::Message const&)
20  0x7fd2e8f2cc33 content::RenderViewImpl::OnMessageReceived(IPC::Message const&)
21  0x7fd2e7b54b37 IPC::MessageRouter::RouteMessage(IPC::Message const&)
22  0x7fd2e7b54a78 IPC::MessageRouter::OnMessageReceived(IPC::Message const&)
23  0x7fd2e8433dd3 content::ChildThreadImpl::OnMessageReceived(IPC::Message const&)
24  0x7fd2e86be3f7
25  0x7fd2e8721fd3
26  0x7fd2eadd2759 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
27  0x7fd2e0e10ac7 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue*, scheduler::in
ternal::TaskQueueImpl::Task*)
28  0x7fd2e0e0f754 scheduler::TaskQueueManager::DoWork(base::TimeTicks, bool)
29  0x7fd2e0e11a29
30  0x7fd2eadd2759 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
31  0x7fd2eadfd085 base::MessageLoop::RunTask(base::PendingTask const&)

 
David, do you think you could take a look at this?

Comment 2 by bokan@chromium.org, Jul 4 2016

Yup, I just saw this stacktrace myself, I'll take a look today

Comment 3 by bokan@chromium.org, Jul 4 2016

Cc: ymalik@chromium.org skobes@chromium.org bokan@chromium.org
 Issue 624293  has been merged into this issue.
Blocking: 589726
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ba06781913559370207cd5be4756c1d706fd14

commit 08ba06781913559370207cd5be4756c1d706fd14
Author: bokan <bokan@chromium.org>
Date: Wed Jul 13 02:41:41 2016

Disable compositing asserts when gesture scrolling on main thread

These asserts get tripped when ScrollAnimator tries to determine if the
scroller needs to be scrolled on the main thread or on the impl thread.

Also moved the early-out if there's no FrameView on GestureScrollBegin
to all GestureScroll events since we shouldn't handle any of those if
there's no view.

BUG= 625676 

Review-Url: https://codereview.chromium.org/2120373002
Cr-Commit-Position: refs/heads/master@{#404922}

[modify] https://crrev.com/08ba06781913559370207cd5be4756c1d706fd14/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/08ba06781913559370207cd5be4756c1d706fd14/third_party/WebKit/Source/core/input/ScrollManager.cpp

Comment 6 by yosin@chromium.org, Jul 13 2016

Components: Blink>Scroll

Comment 7 by bokan@chromium.org, Jul 13 2016

Status: Fixed (was: Assigned)
I've landed the fix. Please reopen if you still see this.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ba06781913559370207cd5be4756c1d706fd14

commit 08ba06781913559370207cd5be4756c1d706fd14
Author: bokan <bokan@chromium.org>
Date: Wed Jul 13 02:41:41 2016

Disable compositing asserts when gesture scrolling on main thread

These asserts get tripped when ScrollAnimator tries to determine if the
scroller needs to be scrolled on the main thread or on the impl thread.

Also moved the early-out if there's no FrameView on GestureScrollBegin
to all GestureScroll events since we shouldn't handle any of those if
there's no view.

BUG= 625676 

Review-Url: https://codereview.chromium.org/2120373002
Cr-Commit-Position: refs/heads/master@{#404922}

[modify] https://crrev.com/08ba06781913559370207cd5be4756c1d706fd14/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/08ba06781913559370207cd5be4756c1d706fd14/third_party/WebKit/Source/core/input/ScrollManager.cpp

Labels: Hotlist-Input-Dev

Sign in to add a comment