New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625662 link

Starred by 2 users
Status: Fixed
Owner:
█ andersoncss@google.com
Email to this user bounced
Closed: Aug 2016
Cc:
georgesak@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Wrong Comment in BrowserProcess->GetTabManager() function

Project Member Reported by andersoncss@google.com, Jul 4 2016 
The function always returns a TabManager if running in a supported platform. If it isn't create, it creates one and returns it. 

https://cs.chromium.org/chromium/src/chrome/browser/browser_process.h?sq=package:chromium&rcl=1464621396&l=273
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 5 2016

Labels: Hotlist-Google

Comment 2 by andersoncss@google.com, Aug 15 2016

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85932fdc9902666df10cf6f8216b092c3853bcab

commit 85932fdc9902666df10cf6f8216b092c3853bcab
Author: andersoncss <andersoncss@google.com>
Date: Tue Aug 16 18:24:39 2016

correct comment on GetTabManager

BUG= 625662 

Review-Url: https://codereview.chromium.org/2246163002
Cr-Commit-Position: refs/heads/master@{#412296}

[modify] https://crrev.com/85932fdc9902666df10cf6f8216b092c3853bcab/chrome/browser/browser_process.h

Comment 4 by andersoncss@google.com, Aug 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment