New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625658 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove pre-MD code from NTP

Project Member Reported by bauerb@chromium.org, Jul 4 2016

Issue description

Once the Material Design update on the Android New Tab Page sticks, we should remove the old code and measurements etc.
 
Status: Available (was: Unconfirmed)

Comment 2 by fi...@chromium.org, Jul 29 2016

Labels: -zine-ntp-pe zine-ntp zine-triaged
Owner: mvanouwe...@chromium.org
Status: Assigned (was: Available)
Labels: zine-16-10-10 zine-16-10-03
Status: Started (was: Assigned)
Labels: M-56
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628

commit 4a1aa1c66e22b57962ad79f66a2c3735b4ed8628
Author: mvanouwerkerk <mvanouwerkerk@chromium.org>
Date: Mon Oct 10 13:43:12 2016

Remove unused pre-material NTP styling.

BUG= 625658 

Review-Url: https://codereview.chromium.org/2408643002
Cr-Commit-Position: refs/heads/master@{#424140}

[delete] https://crrev.com/8e3dd5b5d069ca969e2d381a95ed5cdfe3235101/chrome/android/java/res/drawable/bg_ntp_search_box.xml
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/res/layout/new_tab_page_layout.xml
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/res/layout/new_tab_page_recycler_view.xml
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/res/layout/new_tab_page_view.xml
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[delete] https://crrev.com/8e3dd5b5d069ca969e2d381a95ed5cdfe3235101/chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpStyleUtils.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressIndicatorView.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/android/java_sources.gni
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628/chrome/browser/android/logo_service.cc

Status: Fixed (was: Started)

Sign in to add a comment