New issue
Advanced search Search tips

Issue 625643 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Record usage of autofill data after user clicks [Pay] in PaymentRequest

Project Member Reported by rouslan@chromium.org, Jul 4 2016

Issue description

^^^
 
Components: UI>Browser>Autofill>Payments UI>Browser>Autofill
So that frecency algorithms work properly.

Comment 2 by se...@chromium.org, Jul 11 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b85d558587cb6195338161ca6ebcf77f6b7166d

commit 0b85d558587cb6195338161ca6ebcf77f6b7166d
Author: sebsg <sebsg@chromium.org>
Date: Wed Jul 20 22:24:44 2016

Record and log the use of a profile and/or credit card when they get used in in Payment Request. Calls the RecordAndLogUse() method that is currently used in Autofill.

BUG= 625643 
TEST=PersonalDataManagerTest, PaymentRequestUseStatsTest

Review-Url: https://codereview.chromium.org/2126213002
Cr-Commit-Position: refs/heads/master@{#406692}

[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/java_sources.gni
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[add] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestUseStatsTest.java
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/components/autofill/core/browser/autofill_data_model.cc
[modify] https://crrev.com/0b85d558587cb6195338161ca6ebcf77f6b7166d/components/autofill/core/browser/personal_data_manager.h

Labels: Merge-Request-53 M-53
Would like to merge 0b85d558587cb6195338161ca6ebcf77f6b7166d to M-53.

Comment 5 by dimu@google.com, Jul 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04

commit 5b95605f4f9bdd608df1f1dee0aa49fff9e25f04
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jul 22 16:48:34 2016

[Merge M-53] Record and log the use of a profile and/or credit card
when they get used in in Payment Request. Calls the RecordAndLogUse()
method that is currently used in Autofill.

BUG= 625643 
TEST=PersonalDataManagerTest, PaymentRequestUseStatsTest

Review-Url: https://codereview.chromium.org/2126213002
Cr-Commit-Position: refs/heads/master@{#406692}
(cherry picked from commit 0b85d558587cb6195338161ca6ebcf77f6b7166d)

Review URL: https://codereview.chromium.org/2170213003 .

Cr-Commit-Position: refs/branch-heads/2785@{#302}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/java_sources.gni
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryTest.java
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[add] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestUseStatsTest.java
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/components/autofill/core/browser/autofill_data_model.cc
[modify] https://crrev.com/5b95605f4f9bdd608df1f1dee0aa49fff9e25f04/components/autofill/core/browser/personal_data_manager.h

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment