Issue metadata
Sign in to add a comment
|
12.8% improvement in webrtc_perf_tests at 13352:13352 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 4 2016
Hey aluebs, just FYI, seems like a mac perfbot flagged your change in https://codereview.webrtc.org/2053773002 as improving performance a bit.
,
Jul 5 2016
Unclear why this metric was improved.
,
Jul 6 2016
,
Jul 6 2016
This is actually expected, since after this fix only the necessary channels are merged after the beamformer reduces the number of channels. Here is the description of the CL: "Before this change the ChannelBuffer had a fixed number of channels. This meant for example that when the Beamformer would reduce the number of channels to one, the merging filter bank was still merging all the channels, which was unnecessary since they were not processed and just discarded later. This change doesn't change the signal at all. It just reflects the number of channels in the ChannelBuffer, reducing the complexity." |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by brandtr@chromium.org
, Jul 4 2016